Giter Club home page Giter Club logo

Comments (6)

danielwaghorn avatar danielwaghorn commented on June 7, 2024

I also have the same issue which is manifesting itself by the test failing because an aggregate UUID isn't being supplied to the projector.

Ideally Event::fake() would solve this by not allowing the projectors to run, however regardless of whether the fake() method is called in the setUp in the test or just before the actual test case it still runs.

TypeError : Argument 2 passed to App\Projectors\InvoiceProjector::onRaiseFirstInvoice() must be of the type string, null given

I notice that this is when using the given method as below:

BookingAggregate::fake()
            ->given(new RaiseFirstInvoice)
            ->when(function (BookingAggregate $aggregate) {
                $aggregate->raiseInvoice();
            })
            ->assertRecorded(new RaiseSecondInvoice)
            ->assertNotRecorded([
                RaiseFirstInvoice::class,
                RaiseRegularInvoice::class,
            ]);

The tests run fine if I remove the Projector.

from laravel-event-sourcing.

TobiasJ avatar TobiasJ commented on June 7, 2024

Took a quick look at the Spatie\EventSourcing\Projectionist Class and right now it seems that the Spatie\EventSourcing\Projectionist::withoutEventHandlers method suits this case. When I call the method (app(Spatie\EventSourcing\Projectionist::class)->withoutEventHandlers()) before faking the Aggregate the Projectors and Reactors of course do not get triggered. Facade usage \Spatie\EventSourcing\Facades\Projectionist::withoutEventHandlers(); is possible too.

This only works when you don't want any Projectors and Reactors to be triggered.

from laravel-event-sourcing.

riasvdv avatar riasvdv commented on June 7, 2024

Does calling withoutEventHandlers() fix all the issues you're having? Or is there still some unexpected behaviour?

from laravel-event-sourcing.

TobiasJ avatar TobiasJ commented on June 7, 2024

Right now it does fix the issue for me. Couldn't come up with a test scenario where this won't work as we can just trigger manually generated Events to test Projections and Reactions.

But it would be nice to have an option (like retrieve) to supply a UUID to the FakeAggregateRoot in case they are needed for Projections in Integration/Feature Tests. That would also solve @danielwaghorn issue with the Aggregate UUID not being supplied to the Projector.

from laravel-event-sourcing.

danielwaghorn avatar danielwaghorn commented on June 7, 2024

I can confirm that adding Projectionist::withoutEventHandlers(); lets my tests run successfully. This works for me as I'm just testing the Aggregate as a unit. If I'm doing an integration test I tend to want the events handled by the Projectors and therefore present in the database to assert against.

Is this worth me making a PR to the docs to suggest this as a suitable means of disabling projectors rather than Event::fake()?

from laravel-event-sourcing.

riasvdv avatar riasvdv commented on June 7, 2024

Feel free to do so! I'd suggest just adding the Projectionist::withoutEventHandlers(); part with some extra explanation, the Event::fake() can still be used to prevent storing the events as that uses Laravel's event system

from laravel-event-sourcing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.