[Bug]: PHPStan invalid return type: `Laravel\Scout\Builder` about laravel-excel HOT 5 CLOSED

Sadly scout doesnt implement the Builder interface :(
https://github.com/guiwoda/laravel-scout/blob/master/src/Builder.php

from laravel-excel.

It would be better to revert Scout Query and instead just call the underlying query builder with ->query in code

from laravel-excel.

As far as I understood that wouldn't be the same. I don't see any reason to revert the Scout feature.

Not strictly use this type.

Nothing is "strictly" using this type, it's completly opt in. It's just on the doclbock, which Phpstan sees. Nothing breaks functionally.

I don't see your class in your issue, so I'm just guessing. But it sounds like you don't have a return type in your own code, so PHPstan will probably fallback onto the interface doclbock. If you just add \Illuminate\Contracts\Database\Query\Builder as docblock or return type to your own code (like is intended), Phpstan will pass.

from laravel-excel.

@patrickbrouwers but there is an instance of Scout/Builder in code. how Does your code run if the Scout/Builder class is not available in your vendor packages?

at least laravel scout should be added in composer json as dependency

from laravel-excel.

Instanceof checks don't care about the class actually existing. The rest of the logic only runs if the class exists

from laravel-excel.