Giter Club home page Giter Club logo

Comments (6)

SpartanJ avatar SpartanJ commented on July 27, 2024

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


Sorry i forgot to respond, for the moment i have no plans to support sRGB. But i'll keep it in mind for the future, sadly i don't have enough time to research about the topic and i have very little knowledge on how sRGB works. May be if this is a very trivial change and i'm getting a wrong picture about the implementation needed you can give me some tips to take a look at this topic.

Regards

from soil2.

SpartanJ avatar SpartanJ commented on July 27, 2024

Original comment by Malte Haase (Bitbucket: a_teammate, ).


its basicly just the correction of the error that traditionally all displays have (they gamma correct everything they get).

these articles may help you understand that topic:

a nice introduction what linear space is about: http://filmicgames.com/archives/299

a short summary when you need what: http://stackoverflow.com/questions/24781651/when-should-i-use-gl-srgb8-instead-of-gl-rgb8

(+ another more detailed somehow related post on that topic: http://stackoverflow.com/a/10348719 )

basicly for SOIL2 the following trivial things need to be done:

  • add GL_SRGB8 (+ alpha and compressed variants) internal formats (https://www.opengl.org/registry/specs/EXT/texture_sRGB.txt)
  • add a flag like "SOIL_CONVERT_TO_LINEAR" or "SOIL_LOAD_LINEAR_SPACE" for which these corresponding SRGB internal targets will be used (e.g. SOIL_CONVERT_TO_LINEAR ? GL_SRGB8 : GL_RGB8)

Off-Topic: why don't you move to Github btw? i'd think you'd gain from such a move, since contributions are more likely over there (id guess simply bc most oss projects are there and people already got accounts, but also a bit bc of bitbuckets policies)

from soil2.

SpartanJ avatar SpartanJ commented on July 27, 2024

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


Thanks for taking the time to explain me what's all about. It really seems to be a very trivial change so i'll add it in the next days.

About Github, it's just because i like mercurial and i already have my repos here. I know that here my projects are not very exposes but migrating everything wouldn't be so easy. I would prefer to have a mirror in Github, but such service doesn't exists ( but i could use some script for that ). I'll se what i do about it. I sill prefer Bitbucket anyways ( all my private repos are here too, so it's more convenient for me ).

from soil2.

SpartanJ avatar SpartanJ commented on July 27, 2024

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


It'll be implemented, since it's trivial.

from soil2.

SpartanJ avatar SpartanJ commented on July 27, 2024

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


Added sRGB color space support.
Resolved issue #8.

from soil2.

SpartanJ avatar SpartanJ commented on July 27, 2024

Original comment by Malte Haase (Bitbucket: a_teammate, ).


Thanks!

from soil2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.