Giter Club home page Giter Club logo

Comments (4)

SpartanJ avatar SpartanJ commented on June 20, 2024 1

I wanted to ask if there are any other reasons you decided not to enable R8 in your release builds.

Depends, laziness is a good reason? 😆 I skipped the minification exactly because of the issues you mentioned, it's no always easy to know what's going to fail, so better safe than sorry.

One clear benefit of having R8 on is a much-optimized APK size. For example, R8-enabled builds have a 50% reduced APK size as they don't contain many unused/unreferenced parts of the dependencies used by the app.

Yes, I know, but we are talking about an 8MB application, so I honestly did not care at all.

If you don't mind, can I create a PR with these changes?

Sure! If someone already took the time we should enjoy the benefits. 😄

Thanks!

from imgurviewer.

SpartanJ avatar SpartanJ commented on June 20, 2024 1

Thanks, I'll try to prepare a new release this weekend, I forgot about it the last one.

from imgurviewer.

starry-shivam avatar starry-shivam commented on June 20, 2024

Closing as completed, thanks :)

from imgurviewer.

starry-shivam avatar starry-shivam commented on June 20, 2024

Thanks, I'll try to prepare a new release this weekend, I forgot about it the last one.

Great 👌

from imgurviewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.