Comments (4)
I wanted to ask if there are any other reasons you decided not to enable R8 in your release builds.
Depends, laziness is a good reason? 😆 I skipped the minification exactly because of the issues you mentioned, it's no always easy to know what's going to fail, so better safe than sorry.
One clear benefit of having R8 on is a much-optimized APK size. For example, R8-enabled builds have a 50% reduced APK size as they don't contain many unused/unreferenced parts of the dependencies used by the app.
Yes, I know, but we are talking about an 8MB application, so I honestly did not care at all.
If you don't mind, can I create a PR with these changes?
Sure! If someone already took the time we should enjoy the benefits. 😄
Thanks!
from imgurviewer.
Thanks, I'll try to prepare a new release this weekend, I forgot about it the last one.
from imgurviewer.
Closing as completed, thanks :)
from imgurviewer.
Thanks, I'll try to prepare a new release this weekend, I forgot about it the last one.
Great 👌
from imgurviewer.
Related Issues (20)
- Proxy settings are ignored HOT 2
- Catbox.moe Files Not Working HOT 3
- Crash on Android 7.0
- Version 2.3.5 doesn't play local video files HOT 1
- android 13 needs new local permissions HOT 3
- "Couldn't resolve album url" for some reddit albums
- [Enhancement] kappa.lol support
- The 3000 x 4000 image is flipped to the left and becomes across (bug) HOT 2
- setting: pause automatically when exiting the application
- Create a notification when playing a video
- In the "additional" button, the "delete" button (for local videos) (feature req.)
- In the "additional" button, the "change" button (for local videos)
- Can't download images at all HOT 5
- Add a rotate photo button
- Non-animated gifs on Imgur fail with 'Sorry, video reproduction failed'. HOT 2
- Full list of supported hosts? HOT 1
- YouTube Support HOT 3
- gif and gifv playback is laggy HOT 5
- Downloaded files will be saved under Android/data directory on Android13 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imgurviewer.