Giter Club home page Giter Club logo

Comments (7)

weckbach avatar weckbach commented on July 17, 2024

I experience the same problem. Are there any plans to resolve this?

from url-regex-safe.

niftylettuce avatar niftylettuce commented on July 17, 2024

PR welcome!

from url-regex-safe.

birtles avatar birtles commented on July 17, 2024

I worked around this by adapting the path part from:

(?:[/?#][^\s")']*)?

to:

(?:[/?#][^\s")']*[^\s")'.?!])?

which is probably not quite right but seemed to cover all the cases I threw at it

from url-regex-safe.

titanism avatar titanism commented on July 17, 2024

Can you submit a PR and maybe a test? @birtles would love to get this in

from url-regex-safe.

birtles avatar birtles commented on July 17, 2024

Can you submit a PR and maybe a test? @birtles would love to get this in

Sure, I've submitted #29 for this.

from url-regex-safe.

titanism avatar titanism commented on July 17, 2024

v4.0.0 released with this, thank you @birtles

release notes @ https://github.com/spamscanner/url-regex-safe/releases/tag/v4.0.0

note: this version now requires node v14+

from url-regex-safe.

birtles avatar birtles commented on July 17, 2024

Thank you! 🙏

from url-regex-safe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.