Giter Club home page Giter Club logo

Comments (7)

utkubakir avatar utkubakir commented on June 18, 2024 1

Can confirm. They are being updated in the background but neither the sidebar or the setting page shows the update.

Should be fixed on the next release, thanks for letting us know :)

from spacedrive.

zaaakher avatar zaaakher commented on June 18, 2024 1

Oh I didn't notice the sidebar part. I can confirm that the tag updates when I click on the tag in the sidebar. So in general it seems I have to do some action to trigger a UI update (like clicking on the tag from the sidebar or creating a new tag).

It could be an opinionated suggestion but I think an explicit "Save" or "Update" button to save the changes made would actually feel more intuitive and might even be easier to implement.

Nevertheless, here's a goofy little video I just recorded to show the issue discussed in this issue.

from spacedrive.

zaaakher avatar zaaakher commented on June 18, 2024 1

I just tested it now and it seems to be working fine, the color changes when I select it and the text changes when I unfocus from the input element or click the enter key.

from spacedrive.

zaaakher avatar zaaakher commented on June 18, 2024

The only way I was able to update a tag name/color is by creating a new tag which I think triggers the useDebounceFormWatch hook

from spacedrive.

utkubakir avatar utkubakir commented on June 18, 2024

They are updated live (unless that's not working?), maybe we should show a toast to indicate that

from spacedrive.

zaaakher avatar zaaakher commented on June 18, 2024

Unfortunately they're not updated live. If I change a color/name of a tag and then switch to another tag then the first tag I just updated doesn't retain the changes I made to it.

from spacedrive.

utkubakir avatar utkubakir commented on June 18, 2024

For future reference, this is probably related to million.js somehow, code worked before for a long time and magically started working again so...

from spacedrive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.