Giter Club home page Giter Club logo

Comments (8)

dbrgn avatar dbrgn commented on August 21, 2024

You're obviously right.

@rnestler @dns2utf8 @rorist would this be a breaking change in an already published spec if we change the capitalization of one of multiple valid values? Does this need to go into the v14 draft?

from schema.

dbrgn avatar dbrgn commented on August 21, 2024

I just crawled the entire directory. Right now a single space is providing barometer data:

https://hskrk-spacemon.herokuapp.com/

from schema.

rorist avatar rorist commented on August 21, 2024

Hi, maybe we could simplify the sensors. Because now it's almost always an array of objet with value, unit, location, and desc. We could write the specs so its' backward compatible with the detailed sensors, and remove them all, so people can add their own sensors. And still provide examples of sensors.

from schema.

dbrgn avatar dbrgn commented on August 21, 2024

Hm, I think some of the sensors should be standardized, e.g. people now present.

But simplification might be an option.

from schema.

simon-budig avatar simon-budig commented on August 21, 2024

I have no clue how the specification is handled.

For v13 it might be an option to just add "hPa" as enum value in addition to "hPA", and then drop "hPA" in v14. That way it is possible for hackspaces (our hackspace in Siegen actually provides a barometric value of "null" - grgh) to deliver the sensor value correctly without breaking the other hackspaces.

from schema.

dns2utf8 avatar dns2utf8 commented on August 21, 2024

I think it would be a breaking change.
But since it would only apply to two spaces, we could also change both endpoints.

What do you think @HackerspaceKRK @simon-budig ?

from schema.

dbrgn avatar dbrgn commented on August 21, 2024

We don't know whether there are other applications that will consider hPa as invalid. After all, it should be considered invalid according to the published spec. Since it doesn't hurt anyone, I'd actually stick with the wrong writing and fix it in v0.14.

See #3 for v0.14 discussion.

@simon-budig what do you think? :)

from schema.

dns2utf8 avatar dns2utf8 commented on August 21, 2024

This issues is about to be resolved in #7. Please comment there.

from schema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.