Giter Club home page Giter Club logo

Comments (10)

jeremyolliver avatar jeremyolliver commented on July 30, 2024

This will have been introduced in #88

In my opinion package("libpq-dev") shouldn't have been explicitly added, just to safeguard the possibility of a user shooting themselves in the foot by manually changing the attributes containing the package list that should have installed it

from postgresql.

iandelahorne avatar iandelahorne commented on July 30, 2024

To make matters more complicated, if you're using PGDG RPMs for PostgreSQL 9.x, the package will named postgresql93-devel - this should probably be a configurable attribute like node['postgresql']['client']['packages']

from postgresql.

merqlove avatar merqlove commented on July 30, 2024

@lflux, it is already in attr's:

if node['platform_version'].to_f >= 6.0 && node['postgresql']['version'] == '8.4'
  ...
else
  default['postgresql']['client']['packages'] = ["postgresql#{node['postgresql']['version'].split('.').join}-devel"]
end

I don't understand for what this libpq-dev, without checks to Debian/Ubuntu?

from postgresql.

iandelahorne avatar iandelahorne commented on July 30, 2024

@merqlove Oh yeah, you're absolutely correct and I just read the source really fast. Sorry about that.

from postgresql.

merqlove avatar merqlove commented on July 30, 2024

No prob's, @lflux :)
my solution:

# Without this "if" Chef also try to install this package on Centos/RHEL
if ["debian","ubuntu"].include? node['platform']
  package "libpq-dev" do
    action :nothing
  end.run_action(:install)
end

from postgresql.

jeremyolliver avatar jeremyolliver commented on July 30, 2024

That would work. I would suggest you could also remove that entire block (which was only recently added) as libpq-dev is already in the calculated list of package attributes for debian and ubuntu

from postgresql.

cbandy avatar cbandy commented on July 30, 2024

See #99

from postgresql.

michaelkirk avatar michaelkirk commented on July 30, 2024

This should be solved by #151

Are you still having issues @drewvanstone ?

from postgresql.

slyness avatar slyness commented on July 30, 2024

Solved by #151. Closed.

from postgresql.

lock avatar lock commented on July 30, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from postgresql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.