Giter Club home page Giter Club logo

Comments (22)

jayofdoom avatar jayofdoom commented on August 15, 2024

Hey Dominic, I'll toss up a PR to fix this up.

from docker.

jayofdoom avatar jayofdoom commented on August 15, 2024

@bflad Would you be OK on a patch to install this package on 13.10 only? I don't believe it's required on other platforms which may be why the lxc-docker package doesn't properly depend on it.

from docker.

bflad avatar bflad commented on August 15, 2024

Absolutely or I'll fix it tomorrow morning. Thanks!

Brian Flad
Sent from mobile
On Feb 14, 2014 6:04 PM, "Jason Faulkner" [email protected] wrote:

@bflad https://github.com/bflad Would you be OK on a patch to install
this package on 13.10 only? I don't believe it's required on other
platforms which may be why the lxc-docker package doesn't properly depend
on it.

Reply to this email directly or view it on GitHubhttps://github.com//issues/69#issuecomment-35133809
.

from docker.

jayofdoom avatar jayofdoom commented on August 15, 2024

Fixed in #70.

from docker.

bflad avatar bflad commented on August 15, 2024

Hmmm. I was able to start up this container just fine without cgroup-bin. @dlobue Are you setting any specific attributes or could you tell me a little more about your environment? I haven't seen the LWRP tests fail on Ubuntu 13.10 in quite awhile with the defaults and I would imagine that lxc-start error wouldn't be anything specific to an individual image.

$ kitchen test ubuntu-1310 --destroy=never
-----> Starting Kitchen (v1.1.1)
-----> Cleaning up any prior instances of <docker-lwrp-ubuntu-1310>
-----> Destroying <docker-lwrp-ubuntu-1310>...
       Finished destroying <docker-lwrp-ubuntu-1310> (0m0.00s).
-----> Testing <docker-lwrp-ubuntu-1310>
-----> Creating <docker-lwrp-ubuntu-1310>...
       Bringing machine 'default' up with 'virtualbox' provider...
...
Finished tests in 2.002441s, 5.4933 tests/s, 11.4860 assertions/s.

11 tests, 23 assertions, 0 failures, 0 errors, 0 skips
  - MiniTest::Chef::Handler
Running handlers complete

[2014-02-15T14:04:22+00:00] INFO: Report handlers complete
Chef Client finished, 46/56 resources updated in 270.609623571 seconds
       Finished converging <docker-lwrp-ubuntu-1310> (5m8.51s).
-----> Setting up <docker-lwrp-ubuntu-1310>...
       Finished setting up <docker-lwrp-ubuntu-1310> (0m0.00s).
-----> Verifying <docker-lwrp-ubuntu-1310>...
       Finished verifying <docker-lwrp-ubuntu-1310> (0m0.00s).
       Finished testing <docker-lwrp-ubuntu-1310> (6m0.88s).
-----> Kitchen is finished. (6m1.39s)
$ kitchen login ubuntu-1310
Welcome to Ubuntu 13.10 (GNU/Linux 3.11.0-12-generic x86_64)

 * Documentation:  https://help.ubuntu.com/
Last login: Sat Feb 15 13:59:51 2014 from 10.0.2.2
vagrant@docker-lwrp-ubuntu-1310:~$ sudo su -
root@docker-lwrp-ubuntu-1310:~# docker pull hrafique/oracle-jdk7
Pulling repository hrafique/oracle-jdk7
ea7ee44f98e8: Download complete
27cf78414709: Download complete
b750fe79269d: Download complete
9bdf5c5b36d2: Download complete
f57d522f47f9: Download complete
1c05935299fe: Download complete
dee2f218bb75: Download complete
2eafb168b81e: Download complete
940c08e6ab7a: Download complete
64da6d70ebf1: Download complete
d9e4a6640650: Download complete
944cbf2bd009: Download complete
fbe4fd741159: Download complete
root@docker-lwrp-ubuntu-1310:~# docker run hrafique/oracle-jdk7 java -version
java version "1.7.0_51"
Java(TM) SE Runtime Environment (build 1.7.0_51-b13)
Java HotSpot(TM) 64-Bit Server VM (build 24.51-b03, mixed mode)
root@docker-lwrp-ubuntu-1310:~#

from docker.

bflad avatar bflad commented on August 15, 2024

docker is 0.8.0 on the above:

root@docker-lwrp-ubuntu-1310:~# docker version
Client version: 0.8.0
Go version (client): go1.2
Git commit (client): cc3a8c8
Server version: 0.8.0
Git commit (server): cc3a8c8
Go version (server): go1.2
Last stable version: 0.8.0

from docker.

dlobue avatar dlobue commented on August 15, 2024

@bflad Sure. I didn't set any attributes, and I am booting these servers on the Rackspace cloud with the Ubuntu 13.10 PVHVM images.

I am using chef 11.8.2, which I installed using the omnibus package.

Super easy to reproduce. First thing I do after the server boots is wget the chef dpkg, and then install it. I upload a tarball of the cookbooks to the server, set the runlist to "recipe[docker::default]", and finally run chef.

Happens every time.

Dominic

from docker.

bflad avatar bflad commented on August 15, 2024

Great, thanks for the details. I'll try to play with the Rackspace cloud images this weekend.

from docker.

jayofdoom avatar jayofdoom commented on August 15, 2024

@bflad My suspicion (I can't test using your kitchen config due to not having Virtualbox) is that the base image you're using has cgroup-bin preinstalled, whereas the Rackspace image doesn't.

from docker.

jayofdoom avatar jayofdoom commented on August 15, 2024

@bflad If you did want to test this on the Rackspace Cloud, you can get a developer account here: http://developer.rackspace.com/devtrial/ which is $50 of free cloud over 6 months ($300 total).

from docker.

jayofdoom avatar jayofdoom commented on August 15, 2024

Some insight, perhaps, from the docker IRC channel:

13:33 < tianon> davidcollom: you haven't done 'APT::Install-Recommends "0";' have you?
13:34 < tianon> because lxc-docker should've pulled in lxc which should've pulled in cgroup-lite/cgroup-bin

Is is possible the test-kitchen installs reccomends and PVKVM image from Rackspace doesn't?

from docker.

bflad avatar bflad commented on August 15, 2024
vagrant up ubuntu1310 --no-provision
Bringing machine 'ubuntu1310' up with 'virtualbox' provider...
...
[ubuntu1310] Configuring cache buckets...
$ vagrant ssh ubuntu1310
Welcome to Ubuntu 13.10 (GNU/Linux 3.11.0-12-generic x86_64)

 * Documentation:  https://help.ubuntu.com/
Last login: Mon Nov  4 04:06:16 2013 from 10.0.2.2
vagrant@docker-ubuntu-1310:~$ dpkg --get-selections | grep -v deinstall | grep cgroup
vagrant@docker-ubuntu-1310:~$

So no cgroup packages are pre-installed on the Bento image.

from docker.

bflad avatar bflad commented on August 15, 2024

Setup Rackspace account and playing with Ubuntu 13.10 PVHVM image right now.

from docker.

bflad avatar bflad commented on August 15, 2024

Okay, I'm able to (hopefully) replicate. Here's the output from my LXC log:

root@default:~# cat /var/log/lxc/9c9fc514a286846661d3ed9636d7531201a1a59627fc90dbd70096e8f59e93ac.log
      lxc-start 1393818272.545 ERROR    lxc_start - failed to spawn '9c9fc514a286846661d3ed9636d7531201a1a59627fc90dbd70096e8f59e93ac'
       lxc-info 1393818272.545 ERROR    lxc_commands - command get_init_pid failed to receive response

Does this match what your output has? Digging deeper...

from docker.

bflad avatar bflad commented on August 15, 2024

@tianon does have it correct, apt has Install-Recommends turned off by default on at least the Rackspace Ubuntu 13.10 PVHVM image:

root@default:~# cat /etc/apt/apt.conf.d/00InstallRecommends
APT::Install-Recommends "false";

This corroborates with his comment on this bug: https://bugs.launchpad.net/linuxmint/+bug/1257109

I'm going to do some assessment since this could affect more than just 13.10 on Rackspace. The cookbook should handle the required installation on all platforms.

from docker.

bflad avatar bflad commented on August 15, 2024

Affects 12.04 LTS, 12.10, and 13.10 PVHVM images on Rackspace. I'm going to patch docker::cgroups recipe to handle basic package install and services for now, but like the TODO in that recipe says, I'll want to submit the fixes upstream to hw-cookbooks/control_groups at some point.

from docker.

bflad avatar bflad commented on August 15, 2024

I have fix completed and tested for Ubuntu boxes that have Install-Recommends turned off:

11 tests, 23 assertions, 0 failures, 0 errors, 0 skips

Will be in next release.

from docker.

dlobue avatar dlobue commented on August 15, 2024

@bflad @jayofdoom Sorry about that, I do have Install-Recommends off. Guess that's a packaging goof on docker's part.

from docker.

tianon avatar tianon commented on August 15, 2024

The problem here stems from the fact that cgroup-lite (or even an analog to it) doesn't yet exist in Debian. To this end, I've got a package in Debian's NEW just waiting for some review by the ftp-masters called "cgroupfs-mount" that performs the same function, but generally for all Debian-based distros (and the script it contains can be used on almost all distros as well).

Also, I would personally consider it a bug on the majority of Debian-based distros to have Recommends disabled: (from https://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps)

Recommends

This declares a strong, but not absolute, dependency.

The Recommends field should list packages that would be found together with this one in all but unusual installations.

from docker.

paultag avatar paultag commented on August 15, 2024

Yes. I agree with @tianon - sorry, policy disagrees this is a good idea. This field (Recommends) is only there for when people wish to do nonstandard things (and know they're removing vital parts of the package's relations)

Please don't report bugs on anything without having Recommends enabled. Thanks.

from docker.

paultag avatar paultag commented on August 15, 2024

(If it's not already clear, I'm not willing to change a Rec to a Dep simply because people set their config to goofy things.)

from docker.

bflad avatar bflad commented on August 15, 2024

I didn't explicitly call this out but this should've been fixed in chef-docker 0.32.0 if your node winds up calling the cgroups recipe. 0ecd17b

from docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.