Giter Club home page Giter Club logo

Comments (8)

jayofdoom avatar jayofdoom commented on July 17, 2024

Would it make sense for this to be a different action? :force_pull vs :pull? It seems almost analogous to the :create vs :create_if_missing with some of the other resources.

from docker.

jhulten avatar jhulten commented on July 17, 2024

+1 to :pull vs :pull_if_missing. Abstracting the docker cli should behave like the docker cli.

from docker.

bflad avatar bflad commented on July 17, 2024

+1 to separate action

On Mon, Feb 3, 2014 at 1:36 PM, Jeffrey Hulten [email protected]:

+1 to :pull vs :pull_if_missing. Abstracting the docker cli should behave
like the docker cli.

Reply to this email directly or view it on GitHubhttps://github.com//issues/54#issuecomment-33984863
.

Brian Flad
http://about.me/bflad

from docker.

gabrtv avatar gabrtv commented on July 17, 2024

Glad I asked! I'll work up the PR accordingly.

from docker.

bflad avatar bflad commented on July 17, 2024

@gabrtv I'd be a fan of renaming current pull action to pull_if_missing. Thanks so much and let me know if you need any help.

from docker.

jhulten avatar jhulten commented on July 17, 2024

My PR does the following:

  • moves the existing pull action to pull_if_missing.
  • adds a new pull action that checks the hash of the label before and after to determine if the resource updated.

@gabrtv Hope we didn't work at cross purposes. I have the okay from my boss to improve this cookbook on company time.

from docker.

gabrtv avatar gabrtv commented on July 17, 2024

@jhulten #55 looks great to me. The hash check is a nice feature.

@bflad and I were talking about how this problem really applies to more than :pull -- :build, for example, should really exhibit similar behavior. There's probably others.

from docker.

bflad avatar bflad commented on July 17, 2024

I've merged #55 and released 0.28.0, which should fix this behavior. I'll create a separate issue for :build action. Feel free to create others as necessary.

from docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.