Comments (16)
@DavidPostill You're welcome! :) Thanks for putting up with us and reporting this issue in the first place! :P
from sox.
@DavidPostill Feel free to join us in the chat room anytime, but if it's a real bug then posting here is the best :)
from sox.
@DavidPostill Is it one specific function that isn't working correctly? Are you getting anything in the console? We made some changes to the meta question alert function, it no longer displays the diamond on meta sites.
Can you try a fresh install of the official script and let me know if anything changes.
from sox.
@DavidPostill You need to click reset
and choose your options again, I made changes to the way the settings were stored and run, and forgot to add a check for the old version :/
from sox.
@enki-code It looks like almost every function is not working.
Console:
soup injecting fixes
SOUP.user.js (line 1921)
soup init complete
337631 (line 30)
SOX error: There was an error loading the feature "Appearance-fixedTopbar". Please raise an issue on GitHub, and copy the following error log.
sox.user.js (line 194)
Error details:
sox.user.js (line 195)
ReferenceError: StackExchange is not defined
sox.user.js (line 196)
SOX error: There was an error loading the feature "Appearance-metaNewQuestionAlert". Please raise an issue on GitHub, and copy the following error log.
sox.user.js (line 194)
Error details:
sox.user.js (line 195)
ReferenceError: StackExchange is not defined
sox.user.js (line 196)
SOX error: There was an error loading the feature "Appearance-hideSearchBar". Please raise an issue on GitHub, and copy the following error log.
sox.user.js (line 194)
Error details:
sox.user.js (line 195)
ReferenceError: StackExchange is not defined
sox.user.js (line 196)
SOX error: There was an error loading the feature "Comments-quickCommentShortcutsMain". Please raise an issue on GitHub, and copy the following error log.
sox.user.js (line 194)
Error details:
sox.user.js (line 195)
ReferenceError: StackExchange is not defined
sox.user.js (line 196)
soup setup complete
337631 (line 30)
soup JS fixes applied
337631 (line 30)
@shu8 Reset has already been tried. I reset, made a couple of changes and saved.
When I open settings again random setting are unticked (the flags options are one such example).
I also get top bar corruption after roughly every second page reload.
from sox.
Can you make sure you are on the master
version, and that it is version 1.0.2
please?
If it is 1.0.2, it seems the helper functions are not working correctly, but that was (at least I thought it had been) fixed. So could you try and replace line 21:
// @require https://rawgit.com/soscripted/sox/master/sox.helpers.js?v=1.0.2a
to
// @require https://rawgit.com/soscripted/sox/master/sox.helpers.js?v=1.0.2b
(change the final a
to b
) to make sure the latest version of the helper functions are being fetched.
And could you also try disabling SOUP, although that really shouldn't matter we might as well try! :)
If that doesn't work, could you try to add console.log(GM_getValue('SOXSETTINGS'))
just under the /*jshint multistr: true */
(ie. under line 31) and reload and paste the contents of console.
I don't have access to FF right now, I'll try testing on it later tonight, in case it's a FF-only problem
from sox.
Changed line 21 as requested. Get the following error:
I already tried disabling SOUP.
Undid change to line 21.
Added console.log(GM_getValue('SOXSETTINGS'))
Console output:
soup injecting fixes
SOUP.user.js (line 1921)
soup init complete
error-6...1050147 (line 30)
["Appearance-grayOutVotes","Appearance-renameChat","Appearance-exclaim","Appearance-employeeStar","Appearance-bulletReplace","Appearance-addEllipsis","Appearance-fixedTopbar","Appearance-highlightQuestions","Appearance-metaNewQuestionAlert","Appearance-hideHireMe","Editing-kbdAndBullets","Editing-editComment","Editing-editReasonTooltip","Editing-addSBSBtn","Editing-linkQuestionAuthorName","Editing-titleEditDiff","Comments-commentShortcuts","Comments-quickCommentShortcutsMain","Unsorted-sortByBountyAmount","Unsorted-isQuestionHot","Unsorted-answerTagsSearch","Unsorted-metaChatBlogStackExchangeButton","Unsorted-alwaysShowImageUploadLinkBox","Unsorted-addAuthorNameToInboxNotifications"]
sox.user.js (line 32)
SOX error: There was an error loading the feature "Appearance-fixedTopbar". Please raise an issue on GitHub, and copy the following error log.
sox.user.js (line 195)
Error details:
sox.user.js (line 196)
ReferenceError: StackExchange is not defined
sox.user.js (line 197)
SOX error: There was an error loading the feature "Appearance-metaNewQuestionAlert". Please raise an issue on GitHub, and copy the following error log.
sox.user.js (line 195)
Error details:
sox.user.js (line 196)
ReferenceError: StackExchange is not defined
sox.user.js (line 197)
GET http://superuser.com/posts/1050147/revisions
200 OK
264ms
jquery-....min.js (line 4)
SOX error: There was an error loading the feature "Comments-quickCommentShortcutsMain". Please raise an issue on GitHub, and copy the following error log.
sox.user.js (line 195)
Error details:
sox.user.js (line 196)
ReferenceError: StackExchange is not defined
sox.user.js (line 197)
soup setup complete
error-6...1050147 (line 30)
GET http://superuser.com/posts/1050147/ivc/5909?_=1457460313850
204 No Content
169ms
jquery.min.js (line 4)
soup JS fixes applied
error-6...1050147 (line 30)
soup subscribed to realtime feed for question 1050147 on site 3
error-6...1050147 (line 30)
GET https://query.yahooapis.com/v1/public/yql?q=selec...kexchange.com%2Ffeeds%2Fquestions%22&format=json
200 OK
385ms
jquery-....min.js (line 4)
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.
from sox.
ok @DavidPostill weird...
Can you try installing this version: https://gist.github.com/shu8/0a275e3e1f1aa8717b24/raw/8a6b54b97e530081f017e6f0a554c2c2ce4ca285/davidpostillDebugging.user.js which I just added a few more console logs to and linked to a different helper function file.
Make sure no other version of SOX is running, and it is only this new version.
Can you paste the console's log after running that version.
thanks for bearing with me! This is pretty weird :/
from sox.
@shu8 I can confirm this. Fresh install on Chrome/Tampermonkey works just fine and a fresh install on Firefox/Greasemonkey fails. All the errors in the console say StackExchange not defined, yet, I can access it via the console just fine.
I suspect this may be a timing issue.
from sox.
@enki-code ok, it's probably because Greasemonkey/FF blocks access to objects defined by the webpage... There's no point trying that script now @DavidPostill
from sox.
@DavidPostill To update you...
- we've both reproduced this on FF
- it's because FF doesn't let us access window objects
- we kind of know a fix(es)
- but we need to do other things as well for it to actually work
so, it might not be till tomorrow or even the day after till we can push a fix! :/
Sorry! We need to add 'Test on FF' to our non-existent todo list before pushing to master from now on :P
and thanks for reporting the issue and hanging with us! :)
from sox.
@DavidPostill and @enki-code I think I've fixed it. Please could you install this debugging version: https://gist.github.com/shu8/0a275e3e1f1aa8717b24/raw/9526b89f00d22b9023ca60dc9f76976352e5fd64/davidpostillDebugging.user.js and confirm whether it is working for you now?
Thanks :)
from sox.
And you might be glad to know I've created a checklist issue for the future @DavidPostill: #24 ;)
from sox.
@shu8 Confirmed working.
from sox.
@DavidPostill The latest fix has been pushed to master, would you mind installing and confirming that this is working for you as well? Thanks.
from sox.
@shu8 @enki-code Confirmed as fixed. Thanks guys ;)
from sox.
Related Issues (20)
- Top Score icon not visible HOT 3
- Tooltips should be displayed on top, always HOT 2
- Add mention links for answer HOT 4
- Adding Answers on top bar HOT 2
- Swap shortcuts ctrl k and ctrl l HOT 1
- Remove Diamond on site for mods, keep diamond on other sites HOT 4
- Some broken features HOT 5
- Hide respondents' and commenters' name except on hover HOT 2
- (Down)vote tooltip gets mixed-up with tags and links under the question HOT 1
- live preview while writing a comment
- Settings menu gone HOT 3
- Spirit Icon not showing HOT 1
- Mod diamond in the topbar that has notifications of new questions on a site's meta is missing HOT 2
- Open imgur images as larger modals on click - not working HOT 1
- No SOX features applied, only settings icon visible HOT 22
- Sort the flag-summary based on outcome time, so the top entries are the most recent resolved. HOT 2
- Currently isn't functional on Violentmonkey; gear (settings) button and diamond button (meta notifications) in the topbar are missing HOT 8
- Ballot box in moderator election is hidden HOT 3
- Convert Stackoverflow answers link in another answer into bookmarks HOT 1
- AJAX listeners may be run multiple times for the same event HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sox.