CSS - make settings link change color on hover about sox HOT 11 CLOSED

Recommended fix:

• Change inline style of soxSettingsButton to background-image: none; padding: 10px 0 0 0; font-size: 14px; color: #999; height: 24px; width: 36px; (note added height and widths)
• Add class yes-hover

Tested to work in FF 44.0.2

from sox.

@cullub thanks! Shouldn't be a problem; I'll look into this tomorrow

cc @enki-code :)

from sox.

@cullub done :) thanks again!

from sox.

ahh... I forgot, it did that in my original script but must have been left out in the rewrite. Thanks @cullub .

from sox.

@shu8 Installed most recent dev version and this is still all screwy.
@cullub What are you using to create those gifs?

from sox.

@shu8 There is no css rule for 'sox-settings-button' did you forget to push changes? Looks like the yes-hover class needs to still be added?

from sox.

@enki-code and @cullub it's fixed now! It didn't work before because another commit I did overwrote and reversed the fix, as you can see at https://github.com/soscripted/sox/commits/dev/sox.css! whoops! Can you please confirm? (might need to wait a while for rawgit cache to delete)

from sox.

I'm currently using the prod version, and it's not fixed yet... Have you pushed to prod yet?

from sox.

@cullub no.. it's still on dev. No idea when we should push to main branch. @enki-code any idea when we should??

from sox.

@shu8 Computer has been down for a couple of days, onboard lan port died while restarting my machine... lovely huh? Since this is just a userscript, as long as a fix is complete I am fine with it being pushed to master.

from sox.

this issue is now resolved.

from sox.