Comments (9)
What happens when you run this: srb rbi suggest-typed
from sorbet-typed.
It's really weird that the bundler.rbi
would cause that but not cause it in sorbet-typed itself :/
from sorbet-typed.
Are you on the latest version of sorbet? I'm not seeing this error :?
from sorbet-typed.
Oh it seems to happen if you have the bundler.rbi
set to strong
or strict
. It won't error if it's set to true
.
from sorbet-typed.
We've temporarily reverted the change that caused this—that way, we can figure out what caused this situation to arise in the first place before re-merging the PR.
from sorbet-typed.
I'm still confused as to where the Elem
is supposed to be coming from :?
Also, if you want to get rid of the gem.rbi in your project you'll need to delete it yourself. Sorbet doesn't seem to delete files if they're in sorbet-typed, it only overwrites existing files or adds them.
from sorbet-typed.
ok, so it looks like Gem::Specification does indeed extend Enumerable in hidden.rbi
, which would be why there's an issue that CI didn't pick up, because CI doesn't generate any hidden definitions.
class Gem::Specification
extend ::Enumerable
end
So when I removed the explicit extend Enumerable
for Specification in #92, it fixed the problem in CI but not when actually using Sorbet.
from sorbet-typed.
hm, actually this might happen regardless of whether gem.rbi
is there? It seems to be entirely dependent on the typing level of bundler.rbi
. So this problem is probably just caused by bundle exec srb rbi sorbet-typed
not also running suggest-typed. At least, kind of.
from sorbet-typed.
Running suggest-typed
downgrades the file to typed: true
and resolves the issue. It seems as though that file should be able to have a higher strictness though?
from sorbet-typed.
Related Issues (17)
- sorbet-typed's "rake" resulted in 33 errors for actionpack_test.rb.
- VariadicUntypedFunction for a scope with (date = DateTime.now) HOT 1
- Issue with bundler.rbi sig HOT 3
- Proposal to add a little bit more structure to rbi files
- Latest version of actionpack.rbi not compatible with Rails <= 5 HOT 1
- Unable to resolve constant FilterEncryptedAttributes
- Support providing a callback class to after_* methods in ActiveRecord HOT 1
- Clarify how to contribute in the README HOT 1
- Support ActiveRecord::Store
- Open3 method signatures do not allow the optional env hash as first argument
- Conflict between activerecord.rbi and sorbet-typed
- Question: Roadmap for this repo? HOT 1
- Missing definition for `ActiveSupport`'s `sole` method
- Set up spec for the rbi HOT 2
- Type of `Rails.application` should be `YourApp::Application` HOT 2
- Typing for ActionDispatch::ContentSecurityPolicy HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sorbet-typed.