Comments (26)
FYI, I just started a new session under wayland and no longer have this issue. Album art loads correctly.
from plattenalbum.
Hi! Are you using the UI scaling of gtk?
from plattenalbum.
Yes! Okay a few quick tests confirm it's not a Wayland/Xorg issue. I did not have scaling on when I logged into wayland. After UI scaling to 150% and restarting mpdevil I saw the same album art scaling issue.
The issue is not present in either Wayland or Xorg if I reset UI scaling to 100%.
from plattenalbum.
Commit e9ad0b3 should fix this issue. Can you confirm?
from plattenalbum.
So I removed the flatpak and just tried building from source with the new commit using the guidance in your readme.
$ meson setup builddir --prefix=/usr/local
The Meson build system
Version: 1.2.1
Source dir: /tmp/mpdevil
Build dir: /tmp/mpdevil/builddir
Build type: native build
Project name: mpdevil
Project version: 1.10.3
Host machine cpu family: x86_64
Host machine cpu: x86_64
Program msgfmt found: NO
data/meson.build:1:5: ERROR: Program 'msgfmt' not found or not executable
A full log can be found at /tmp/mpdevil/builddir/meson-logs/meson-log.txt
The log just confirms the same error:
Build started at 2023-11-13T10:54:57.492925
Main binary: /usr/bin/python3
Build Options: -Dprefix=/usr/local
Python system: Linux
The Meson build system
Version: 1.2.1
Source dir: /tmp/mpdevil
Build dir: /tmp/mpdevil/builddir
Build type: native build
Project name: mpdevil
Project version: 1.10.3
Build machine cpu family: x86_64
Build machine cpu: x86_64
Host machine cpu family: x86_64
Host machine cpu: x86_64
Target machine cpu family: x86_64
Target machine cpu: x86_64
Program msgfmt found: NO
data/meson.build:1:5: ERROR: Program 'msgfmt' not found or not **executable**
I'm not familiar with meson, you might need to give me some additional guidance. :)
from plattenalbum.
It seems like gettext
is not installed on your system. sudo apt install gettext
should fix this on ubuntu.
from plattenalbum.
Next error was:
Program glib-compile-resources found: NO
I had to install libglib2.0-dev-bin
. Then the meson command worked.
Confirmed, the commit fixed my issue - the album art image is no longer scaled when I use UI scaling.
from plattenalbum.
Next error was:
I'll try to fix the build dependencies in the readme.
Confirmed, the commit fixed my issue - the album art image is no longer scaled when I use UI scaling.
Ok, that is good. But I think it breaks wayland compatibility, is that the case on your machine as well?
from plattenalbum.
After UI scaling to 150% and restarting mpdevil I saw the same album art scaling issue.
Even under wayland? I tested this over here and it seems like the issue only occurs under xorg in combination with UI scaling.
from plattenalbum.
I've looked into it a little deeper and at least over here commit ed899a1 fixes the wayland incompatibility. Can you confirm that there are no regressions compared to e9ad0b3? Also I've updated the readme to improve the build dependencies.
from plattenalbum.
Hmm after rebuilding and installing from your latest, mpdevil no longer starts for me. Neither xorg nor wayland.
from plattenalbum.
Is there any output on the console?
from plattenalbum.
error: app/org.mpdevil.mpdevil/x86_64/master not installed
from plattenalbum.
What am I doing wrong?
from plattenalbum.
I'm not sure. The message looks like a flatpak error. But if I understood you correctly you removed the flatpak for testing. If you installed mpdevil to /usr/local
then a simple /usr/local/bin/mpdevil
should start the program.
from plattenalbum.
Confirmed, I flatpak uninstalled and have been building from source since. The which command indicates it's still executing from /usr/local/bin/mpdevil:
$ which mpdevil
/usr/local/bin/mpdevil
However if I run the executable from the absolute path per your last, then I get a different result:
$ /usr/local/bin/mpdevil
Traceback (most recent call last):
File "/usr/local/bin/mpdevil", line 23, in <module>
from mpd import MPDClient, CommandError, ConnectionError
ModuleNotFoundError: No module named 'mpd'
from plattenalbum.
Okay, I apt installed python3-mpd
from plattenalbum.
It's running now. I'll test things and get back to you.
(Not sure why it built before!? Maybe something I did purged python3-mpd)
from plattenalbum.
Okay, I apt installed python3-mpd
Yes, exactly. You were missing the mpd module.
(Not sure why it built before!? Maybe something I did purged python3-mpd)
It should build fine without it. But I'm not sure how you managed to run it the last time.
from plattenalbum.
The which command indicates it's still executing from /usr/local/bin/mpdevil:
Weird, may I ask what you executed to get the flatpak error before?
from plattenalbum.
Just ran mpdevil
at the command line.
$ mpdevil
error: app/org.mpdevil.mpdevil/x86_64/master not installed
from plattenalbum.
Testing your latest was all successful. Expected album art image sizes (both mini player and standard) under scenarios:
Wayland:
- No UI scaling (100%)
- UI scaling (150%)
xorg:
- No UI scaling (100%)
- UI scaling (150%)
from plattenalbum.
Ok, good. I'll try to make a new release soon.
from plattenalbum.
Maybe when /usr/local/bin/mpdevil
failed, something caused it to default to some remnant of my fltapak install?
from plattenalbum.
Awesome, thanks so much for your fast response and fixes.
from plattenalbum.
Maybe when /usr/local/bin/mpdevil failed, something caused it to default to some remnant of my fltapak install?
I'm not sure but it definitely looks like a flatpak issue. After a quick search I found various reports of similar problems. I hope this repairs itself after you reinstall the flatpak. Also flatpak seems to think you what to start the flatpak from the master branch which I'm not even providing (at least as far as I know).
from plattenalbum.
Related Issues (20)
- Small Dutch translation bugs HOT 3
- ALL item HOT 4
- Multiple selection HOT 3
- MPRIS duplication HOT 5
- Window no longer fits on RasPi touchscreen HOT 4
- Artist search fails with hyphen HOT 2
- AttributeError: 'gi.repository.Adw' object has no attribute 'PreferencesDialog'. Did you mean: 'PreferencesWindow'? HOT 2
- Fails to connect if there are no songs in the music directory HOT 6
- Play all songs HOT 1
- fix/update for Gentoo ebuild HOT 5
- Right click actions? HOT 3
- Add support for mpdmomd and mpdfavd HOT 1
- Interactive search in artist list doesn't work anymore HOT 8
- Artist list exhibits stuttery scrolling behavior when scrolling with trackpad HOT 25
- tray (notification status bar) support HOT 3
- Artist List where Artist is just one alpha HOT 2
- Feedback on new album cover scaling algorithm HOT 5
- Server statistics are wrong when mounting a networked storage through `mpd` HOT 2
- Artist list does not restore previous position and fails to render completely HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plattenalbum.