Comments (5)
I didn't see fallback specifically in the example, but cb.Execute
returns a specific error immediately if the request is not going to be allowed (this is documented). It looks like you can check for gobreaker.ErrOpenState
to trigger fallback logic. Something like:
mySuccessReturn, err := cb.Execute(func() (interface{}, error) {
// do stuff
})
if err != nil {
if errors.Is(err, gobreaker.ErrOpenState) {
// circuit is open
// this is where a fallback option happens
} else { // this will be the returned error from "do stuff"
}
}
from gobreaker.
Which fallback function are you referring to? Do you mean callback functions?
https://github.com/sony/gobreaker/blob/master/gobreaker.go#L106-L107
from gobreaker.
Hi, @YoshiyukiMineo ,
in hystrix pattern, an optional fallback function is used when the original func failed. Here's the wiki.
from gobreaker.
@timjonesdev what you suggested to implement the circuit breaker default fallback is good as it's true. However, if there's a default function passed with the setting struct it will be more easy to point, simple to change without touch the actual implementation, and descriptive for each service.
Its an opinion at the end.
from gobreaker.
@ahmedashraff hello, i think we can customize trigger conditions by replacing cb.afterRequest(generation, err != nil)
with cb.afterRequest(generation, cb.shouldChangeState(err))
like this:
type CircuitBreaker struct {
...
shouldChangeState func(err error) bool
}
func defaultShouldChange(err error) bool {
return err != nil
}
func (cb *CircuitBreaker) Execute(req func() (interface{}, error)) (interface{}, error) {
...
result, err := req()
cb.afterRequest(generation, cb.shouldChangeState(err))
return result, err
}
from gobreaker.
Related Issues (20)
- start a new release? HOT 1
- println -> printf HOT 1
- [question/proposal] Monitoring
- breaker for host+service HOT 6
- Why don't use a rolling window to maintain the counts? HOT 2
- Create a new release for module support HOT 2
- Does this really require go 1.12? HOT 4
- race conditions HOT 1
- Confusion about ErrTooManyRequests error HOT 4
- May I request a new release with tag HOT 2
- It will cause a deadlock when call breaker.Counts() method in the OnStateChange() method HOT 3
- breaker per url HOT 1
- example: HTTP circuit breaker doesn't consider HTTP status codes which are more indicative of retryable errors HOT 1
- Reproducing "too many requests"
- Circuitbreaker not performing MaxRequests operations in Half-open state HOT 3
- is circuit breaker threadsafe? HOT 1
- [question/proposal] Monitoring HOT 1
- Will using aync/atomic for incrementing and loading/storing the counts improve performance?
- Exported type for errors HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gobreaker.