Giter Club home page Giter Club logo

Comments (8)

leecalcote avatar leecalcote commented on July 1, 2024

Thanks for submitting this issue, @wolf31o2.

from fluent-plugin-papertrail.

wolf31o2 avatar wolf31o2 commented on July 1, 2024

I should say that it doesn't appear to be a direct dependency, but is getting pulled into the dependency graph during installation. Installing newer versions of msgpack doesn't seem to help.

from fluent-plugin-papertrail.

seth-macpherson avatar seth-macpherson commented on July 1, 2024

@wolf31o2 My experience here was that msgpack wouldn't install because of a hard dependency on gem 'aws-sdk', '2.3.0'. Granted, this may not be your issue but none of my fluent based gems would update with ruby 2.4 because of the aws locked version. Best of luck!

from fluent-plugin-papertrail.

cce avatar cce commented on July 1, 2024

While msgpack is not a direct dependency of this plugin, msgpack [">= 0.7.0", "< 2.0.0"] is a dependency of fluentd: https://github.com/fluent/fluentd/blob/master/fluentd.gemspec

And of course this plugin depends on fluentd: https://github.com/solarwinds/fluent-plugin-papertrail/blob/master/fluent-plugin-papertrail.gemspec#L23

According to msgpack/msgpack-ruby#120 msgpack-ruby >= 1.0.0 works on Ruby 2.4. This should also be allowed according to fluentd's gemspec, and fluentd's release notes say it has supported Ruby 2.4 since January 2017.

@seth-macpherson neither this plugin, fluentd, nor msgpack require the aws-sdk gem, but @wolf31o2 this may be a thread you could try and follow. Are you installing this gem in a global or shared location mixed with dependencies from other projects/gems? If so they may be interfering with the ability of fluentd's gemspec to choose a msgpack version >= 1.0.0 that can work on Ruby 2.4.

from fluent-plugin-papertrail.

wolf31o2 avatar wolf31o2 commented on July 1, 2024

I've installed fluentd using treasure data's td-agent omnibus-based RPM installer. This installs into a prefix with it's own ruby and gems.

$ td-agent-gem list --all

*** LOCAL GEMS ***

addressable (2.5.2)
aws-partitions (1.42.0)
aws-sdk-core (3.11.0)
aws-sdk-kms (1.3.0)
aws-sdk-s3 (1.8.0)
aws-sdk-sqs (1.3.0)
aws-sigv4 (1.0.2)
bigdecimal (default: 1.3.0)
bundler (1.16.0)
cool.io (1.5.3)
did_you_mean (1.1.0)
dig_rb (1.0.1)
elasticsearch (5.0.4)
elasticsearch-api (5.0.4)
elasticsearch-transport (5.0.4)
excon (0.60.0)
faraday (0.13.1)
ffi (1.9.23)
fluent-logger (0.7.1)
fluent-plugin-datadog (0.9.6)
fluent-plugin-elasticsearch (2.4.0)
fluent-plugin-kafka (0.6.5)
fluent-plugin-rewrite-tag-filter (2.0.1)
fluent-plugin-s3 (1.1.0)
fluent-plugin-systemd (0.3.1)
fluent-plugin-td (1.0.0)
fluent-plugin-td-monitoring (0.2.3)
fluent-plugin-webhdfs (1.2.2)
fluentd (1.0.2)
hirb (0.7.3)
http_parser.rb (0.6.0)
httpclient (2.8.2.4)
io-console (default: 0.4.6)
ipaddress (0.8.3)
jmespath (1.3.1)
json (default: 2.0.4)
ltsv (0.1.0)
mini_portile2 (2.3.0)
minitest (5.10.1)
mixlib-cli (1.7.0)
mixlib-config (2.2.4)
mixlib-log (1.7.1)
mixlib-shellout (2.2.7)
msgpack (1.2.0)
multi_json (1.12.2)
multipart-post (2.0.0)
net-telnet (0.1.1)
nokogiri (1.8.1)
ohai (6.20.0)
oj (3.3.9)
openssl (default: 2.0.5)
parallel (1.12.1)
power_assert (0.4.1)
psych (default: 2.2.2)
public_suffix (3.0.1)
rake (12.0.0)
rdoc (default: 5.0.0)
ruby-kafka (0.5.1)
ruby-progressbar (1.9.0)
rubyzip (1.2.1)
serverengine (2.0.5)
sigdump (0.2.4)
strptime (0.1.9)
systemd-journal (1.3.1)
systemu (2.5.2)
td (0.15.7)
td-client (1.0.4)
td-logger (0.3.27)
test-unit (3.2.3)
thread_safe (0.3.6)
tzinfo (1.2.4)
tzinfo-data (1.2017.3)
webhdfs (0.8.0)
xmlrpc (0.2.1)
yajl-ruby (1.3.1)
zip-zip (0.3)

Here's the explain

td-agent-gem install fluent-plugin-papertrail --explain
Gems to install:
  msgpack-0.5.12
  json-1.8.6
  yajl-ruby-1.3.1
  cool.io-1.5.3
  http_parser.rb-0.6.0
  sigdump-0.2.4
  thread_safe-0.3.6
  tzinfo-1.2.4
  tzinfo-data-1.2017.3
  fluentd-0.10.62
  uuidtools-2.1.5
  fluent-mixin-config-placeholders-0.2.4
  syslog_protocol-0.9.2
  fluent-plugin-papertrail-0.1.1

This Gem's gemspec restricts the version of fluentd (and fluent-mixin-config-placeholder) and causes this issue.

# git clone https://github.com/wolf31o2/fluent-plugin-papertrail.git
Cloning into 'fluent-plugin-papertrail'...
remote: Counting objects: 113, done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 113 (delta 3), reused 14 (delta 3), pack-reused 96
Receiving objects: 100% (113/113), 32.88 KiB | 0 bytes/s, done.
Resolving deltas: 100% (35/35), done.
# cd fluent-plugin-papertrail/
# git checkout GH6-loosen-gemspec && td-agent-gem build fluent-plugin-papertrail.gemspec
Branch GH6-loosen-gemspec set up to track remote branch GH6-loosen-gemspec from origin.
Switched to a new branch 'GH6-loosen-gemspec'
WARNING:  description and summary are identical
WARNING:  open-ended dependency on syslog_protocol (>= 0) is not recommended
  if syslog_protocol is semantically versioned, use:
    add_runtime_dependency 'syslog_protocol', '~> 0'
WARNING:  See http://guides.rubygems.org/specification-reference/ for help
  Successfully built RubyGem
  Name: fluent-plugin-papertrail
  Version: 0.1.1
  File: fluent-plugin-papertrail-0.1.1.gem
# td-agent-gem install fluent-plugin-papertrail-0.1.1.gem --explain
Gems to install:
  syslog_protocol-0.9.2
  dig_rb-1.0.1
  strptime-0.1.9
  thread_safe-0.3.6
  tzinfo-1.2.4
  tzinfo-data-1.2017.3
  sigdump-0.2.4
  http_parser.rb-0.6.0
  serverengine-2.0.5
  cool.io-1.5.3
  yajl-ruby-1.3.1
  msgpack-1.2.0
  fluentd-1.0.2
  uuidtools-2.1.5
  fluent-mixin-config-placeholders-0.4.0
  fluent-plugin-papertrail-0.1.1

from fluent-plugin-papertrail.

alexouzounis avatar alexouzounis commented on July 1, 2024

nice! thanks for digging through this :)

from fluent-plugin-papertrail.

cmrust avatar cmrust commented on July 1, 2024

Automatically closed when I merged the branch into my fork. Reopening the issue until it's merged back into Master.

from fluent-plugin-papertrail.

cmrust avatar cmrust commented on July 1, 2024

@wolf31o2 Thanks for the PR and issue! Please feel free to reopen this issue if it doesn't suffice.

from fluent-plugin-papertrail.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.