Comments (4)
Thanks @jackson-sandland!
from solana.
For the unsafe calls to expect()
, is a panic still acceptable on err
as long as there are good error messages? Since multiple calls to unwrap()
will print the same panic message, doesn't it make more sense to use expect()
, instead of unwrap()
, with an error message detailed enough to indicate where the panic occurred?
from solana.
I think replacing every call to unwrap()
with expect("something unique")
would be a first good step.
from solana.
Sounds good. I'll start there. I'll leave off replacing calls to unwrap()
in tests / benchmarking.
from solana.
Related Issues (20)
- Flaky Test: solana-cli::vote test_offline_vote_authorize_and_withdraw
- Failed to start validator: PoH is slower than cluster target tick rate! HOT 1
- CPU metric doesn't show utilization of cores
- Inconsistent cargo build tools interface HOT 1
- solana-test-validator rpc responsecode 502
- Error: IDL for program `day_1` does not have `metadata.address` field. HOT 3
- Unify the uses of `PurgeType::Exact` and `purge_from_next_slots`
- Help Needed - Solana Validator Node not syncing HOT 1
- The new account created has no funds and cannot be transferred unless `--allow-unfunded-recipient` is added. HOT 1
- Solana crashes when sysctl can't be accessed HOT 1
- Transfer issues HOT 1
- anchor build fails HOT 3
- Flaky Test: solana-cli::program test_cli_program_deploy_no_authority
- Fastboot fails if the node crashes while archiving a full snapshot HOT 1
- Possible Incompleteness HOT 5
- Fastboot fails if loading from the same snapshot multiple times
- Large Stack Variables Error in Solana-cli 1.18.1 and Anchor 0.29.0 HOT 2
- error: Unable to update registry crates-io when I run `cargo build-bpf` HOT 2
- Compilation error on ARM 64bit architecture HOT 1
- Compilation for Raspberry Pi 4 with 64-bit ARM architecture does not work. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solana.