Support AspNetCore 3.1 about signalr_client HOT 13 OPEN

Like you I needed the auto-reconnect hence the fork and code alignment with the TS library supported by Microsoft as I knew that had the auto-reconnect feature. FYI, I also intend to branch to support alignment with .NET 5 once released. Messagepack isn't a priority for me as yet but maybe it'll become one in the future.

I'd say I'd have to agree with your assumption re maintenance of the original repository. As for my fork, I will eventually use it in production so if I find any issues that I can fix myself then I shall.

from signalr_client.

@sefidgaran that's great. I'll incorporate your fix into my branch and create a PR asap.

from signalr_client.

I've created the PR for this over on @sefidgaran fork.

from signalr_client.

Has this been tested in a production environment in the meantime?

from signalr_client.

I've only used it in a non-production environment. I've not found any issues other than one I fixed in recent times. That doesn't mean there aren't issues, hence the request (long ago) for testing.

from signalr_client.

Alright, thank you for the prompt response. We're still deciding if we'll use Flutter or not. As we'll need auto-reconnect and support for Dotnet Core 3.1 we'll try your version instead of the original one. Support for messagepack would be good too, but not strictly required.

Judging from the growing list of issues and the lack of responses, it looks like the original package is not actively maintained anymore.

from signalr_client.

Alright, as promised, gave your version a try. Seems to work as expected, no issues to report thus far.

Hope @soernt can accept a PR (or even better a co-maintainer!), or @markphillips100 can publish a new package!

from signalr_client.

@markphillips100 would you consider packaging your version?

from signalr_client.

Looks like somebody already has published a fork, albeit of the original code. https://pub.dev/packages/signalr_netcore.

Maybe @sefidgaran will accept a PR?

from signalr_client.

Interesting... although not entirely clear to me what the fork brings over the existing package!

@sefidgaran please consider PR from @markphillips100!

from signalr_client.

I sent my PR and it is still pending on this package, as it seems this package is not maintained by the owner, decided to publish a fork after fixing issue #41 and use it. I will consider PR. thanks.

from signalr_client.

Hi, may I know when can have the auto-reconnect feature

from signalr_client.

I believe @sefidgaran has merged my PR and released 0.1.8 of signalr_netcore. This version supports the auto-reconnect API - see MS Typescript client doco for usage.

Incidentally, there appears to be another signalr dart package signalr_core that supports aspnetcore 3.1 functionality. The author has told me this was written with code parity to 3.1 Typescript client, and he plans to comply with any changes introduced by .net 5. Has anybody used it?

from signalr_client.