Giter Club home page Giter Club logo

Comments (9)

nexxai avatar nexxai commented on June 25, 2024

Just for posterity's sake:

Screenshot 2024-04-23 at 5 33 44 PM

from providers.

nexxai avatar nexxai commented on June 25, 2024

Created PR here: #1199

from providers.

atymic avatar atymic commented on June 25, 2024

@nexxai does the provider by default request access to fields outside of the ones with the default scope?
You should call ->scopes() when you use the redirect method to set custom scopes, as this PR changes the default for all users which will break anyone not approved for this scope

from providers.

nexxai avatar nexxai commented on June 25, 2024

I will try using the ->scopes() method and update this thread, but according to the docs, it says this scope should be required anyways.

Screenshot 2024-04-25 at 5 05 50 PM

from providers.

nexxai avatar nexxai commented on June 25, 2024

Ok, I can confirm that using this worked:

    return Socialite::driver('tiktok')
            ->scopes(['user.info.basic', 'user.info.profile'])
            ->redirect();

That said, I still think the default should be to include user.info.profile since you can't technically use Socialite with its defaults for logging in to your Laravel app without it.

from providers.

atymic avatar atymic commented on June 25, 2024

Hmm. Which field is included by default that triggers the error? ie required the profile scope?
We can release a new major version to make sure we dont break existing.

from providers.

nexxai avatar nexxai commented on June 25, 2024

I couldn't tell which specific field was triggering the error; the only error message I got was the one I posted in the OP of this thread and it gets truncated before it specifies the missing field.

At the end of the day, a new major version probably makes the most sense since it is definitely a breaking change, but also aligns the intent of the Socialite provider with the reality of what TikTok is providing, and also aligns with the documentation we already have in the repo.

from providers.

atymic avatar atymic commented on June 25, 2024

Okay, looking at the docs, username required that scope, which was broken by #1110
Fixed in #1183

from providers.

atymic avatar atymic commented on June 25, 2024

There is no BC break now, add the scope if you want the username

from providers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.