Giter Club home page Giter Club logo

Comments (3)

bearoso avatar bearoso commented on September 28, 2024

@OV2, can we just remove the S9xGraphicsDeinit and S9xGraphicsInit from the dialog's calling code? From what I see it should only be affected by the core pixel format, so we don't need to reset this on frontend changes.

Settings.BG_Forced and Settings.ForcedBackdrop should probably be reset somewhere else like the rest of Settings members, but I don't think it's a good idea to make these even semi-permanent settings. Someone might change them and not know how to switch them back.

from snes9x.

OV2 avatar OV2 commented on September 28, 2024

I think those are leftover from when we supported different pixel formats in the core (which was only used by ddraw). We can probably remove them.

from snes9x.

ReyVGM avatar ReyVGM commented on September 28, 2024

@OV2, can we just remove the S9xGraphicsDeinit and S9xGraphicsInit from the dialog's calling code? From what I see it should only be affected by the core pixel format, so we don't need to reset this on frontend changes.

The same thing I reported causes the Fast-forward toggle hotkey to reset itself when in use.

Settings.BG_Forced and Settings.ForcedBackdrop should probably be reset somewhere else like the rest of Settings members, but I don't think it's a good idea to make these even semi-permanent settings. Someone might change them and not know how to switch them back.

I don't know what this means exactly, but any disabled backgrounds reset themselves if you close and reopen the emulator.

But, speaking of which, a hotkey toggle to enable all disabled backgrounds would actually be a good idea.

from snes9x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.