Comments (5)
This totally breaks XG, notes will not play
from dmxopl.
Numeric of GS banks is going as:
Wher real combined MSB and LSB by my formula when thinking as Bank Number is unsigned 16-bit integer. Same you will catch inside of MIDI file (MSB event is GS-specific event. LSB bank event is XG event. Possible to use both of them).
Real | MSB |
---|---|
0 | 0 |
256 | 1 |
512 | 2 |
768 | 3 |
1024 | 4 |
1280 | 5 |
1536 | 6 |
1792 | 7 |
2048 | 8 |
2304 | 9 |
4096 | 16 |
6144 | 24 |
8192 | 32 |
and when I have made a dummy MIDI file that uses this bank:
Then, it working fine!
Just for a comparison, same test which uses zero bank:
from dmxopl.
One note came from this issue: Wohlstand/libADLMIDI#136
Extra LSB bank numbers are giving next additions:
1 being SC55, 2 being SC88, 3 SC88 Pro, 4 SC8820
The 0'th LSB is the default fallback, and 1,2,3,4 are meaning different version of same instrument per each synthesizer.
libADLMIDI now supports correct MSB and LSB logic for GS on it's backend, the one thing is left - to polish the bank itself to equip it with necessary instruments.
from dmxopl.
...wait.
Let's say we have a GS Bank no. 8 (MSB=8). It's needed to create a separate bank for SC-55 only instruments (LSB=1), another separate bank for SC-88 instruments (LSB=2) and so on?
from dmxopl.
If there are different - yes, but keep the LSB=0 to be a default fallback. When given LSB is missing, it falls into 0 on the same MSB.
from dmxopl.
Related Issues (20)
- Replace Trumpet HOT 3
- Fix Offset "fixed" voices being softer than they once were HOT 1
- Fix Strings sounding like accordions in some instances HOT 1
- Document DMX quirk HOT 6
- Music Box and Glockenspiel need improvement HOT 6
- Replace some instruments I may have botched HOT 8
- New Toms HOT 10
- Guiro may be too bassy HOT 2
- Rock organ sounds like strings section sometimes HOT 4
- Revisit cymbals for WOPL HOT 1
- Ride Cymbals need work HOT 4
- Better Hats HOT 2
- Any plan for SC8820 GS set? HOT 1
- The XG/GS "Issue" HOT 2
- Possible "OPL" GENMIDI HOT 5
- Merge custom DMXOPL mod into GS GENMIDI .wopl file HOT 2
- Tying up loose ends HOT 14
- Current State of the DMXOPL Project HOT 7
- Investigate D_DOOM issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dmxopl.