Giter Club home page Giter Club logo

Comments (15)

TorchedSammy avatar TorchedSammy commented on May 27, 2024 2

@Snazzah yep, I can open another PR with the changes in a while

from sublimediscordrp.

Snazzah avatar Snazzah commented on May 27, 2024

If you can send me some examples of icons that could look better than the current icons I can consider replacing them.

from sublimediscordrp.

Calvin-rgb avatar Calvin-rgb commented on May 27, 2024

What resolution should the icons be in? .png (What is the resolution? 512x512, 256x256, 64x54) ot .svg (vector)? @Snazzah

from sublimediscordrp.

Snazzah avatar Snazzah commented on May 27, 2024

@dmsass 512x512

from sublimediscordrp.

Snazzah avatar Snazzah commented on May 27, 2024

For reference, here are the current icons on the application.

I do agree that there lacks any consistency in style, I am open to any changes.

from sublimediscordrp.

botatooo avatar botatooo commented on May 27, 2024

My suggestions

javascript: https://upload.wikimedia.org/wikipedia/commons/thumb/9/99/Unofficial_JavaScript_logo_2.svg/512px-Unofficial_JavaScript_logo_2.svg.png
python: https://upload.wikimedia.org/wikipedia/commons/thumb/c/c3/Python-logo-notext.svg/512px-Python-logo-notext.svg.png
rust: https://www.rust-lang.org/logos/rust-logo-512x512-blk.png
text: https://upload.wikimedia.org/wikipedia/commons/thumb/a/ae/Icon-txt.svg/512px-Icon-txt.svg.png
typescript: https://www.typescriptlang.org/icons/icon-512x512.png
unknown: lets use twemoji cause why not https://discord.com/assets/aef26397c9a6a3afee9c857c5e6f3317.svg
v: https://vlang.io/img/v-logo.png

sass because cool
sass: https://sass-lang.com/assets/img/logos/logo-b6e1ef6e.svg

from sublimediscordrp.

Snazzah avatar Snazzah commented on May 27, 2024

@botatooo I replaced the V logo and Python logo

  • The JS and TS logos you provided are a bit less consistent and might clip the text when using the big_icon setting.
  • I'm considering replacing the ? unknown logo with a blank file icon
  • Rust is more or less the same as it is already, maybe add a color background like for JS and TS? (Same for Sass)

from sublimediscordrp.

botatooo avatar botatooo commented on May 27, 2024

i’ve found this for javascript, seems to fit with html and css’s design
javascript

for typescript idk if we could fix that because that’s the logo they use in their marketing and stuffs

from sublimediscordrp.

FichteFoll avatar FichteFoll commented on May 27, 2024

From what I've seen, the first suggestion for the JS logo is indeed the most commonly used icon, but I see no benefit of using it over the better suited logo we currently have that allows it to be cut off a bit at the edges.

from sublimediscordrp.

TorchedSammy avatar TorchedSammy commented on May 27, 2024

my fork has custom consistent icons that i think are really nice :l

if you want i can just zip em up and upload

from sublimediscordrp.

Snazzah avatar Snazzah commented on May 27, 2024

@TorchedSammy Those icons look great! Could you upload them in a zip?

from sublimediscordrp.

TorchedSammy avatar TorchedSammy commented on May 27, 2024

Here they are, ill probably make a separate repo for convenience

from sublimediscordrp.

Snazzah avatar Snazzah commented on May 27, 2024

@TorchedSammy we could just make a folder in the repo to add the icons into for anyone that wants to use their own application ID

from sublimediscordrp.

TorchedSammy avatar TorchedSammy commented on May 27, 2024

@Snazzah oh yea, feel free to and for any new icons ya can just ask me if you'd like

from sublimediscordrp.

Snazzah avatar Snazzah commented on May 27, 2024

@TorchedSammy Also, speaking of your fork, would it be alright if you pushed some changes here? I've been meaning to get this package updated a bit anyways.

from sublimediscordrp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.