Issues when vnode.data is undefined about snabbdom-to-html HOT 11 CLOSED

hey @TylorS

The fix is coming today. 👍

I wonder if you're creating vnodes manually, using the h function always yields an empty object for data.

from snabbdom-to-html.

I generally wrap up h() using hyperscript-helpers
Maybe thats my issue, but I don't believe it should be.

from snabbdom-to-html.

It could be some of the stuff I do in motorcycle as well

from snabbdom-to-html.

@TylorS no worries. I'll add the protection which is nice to have anyways…

from snabbdom-to-html.

👍 I appreciate it @acstll

from snabbdom-to-html.

Glad to help! 2.0.1 has the fix.

from snabbdom-to-html.

Super speedy! Thanks again.

Not sure if it's something you're interested in, but I whipped up this little library you may be interested in https://github.com/TylorS/snabbdom-selector. It basically just takes a snabbdom vTree and parses it for css-selectors. I'm attempting to use it for Motorcycle, but I'm not sure if it would be handy for you or others..

from snabbdom-to-html.

No problem. 👍

Thanks for sharing. I'll let you know if I find a use for it. One thing I noticed is that it might be a good idea to abstract the parseSelector function into its own module so we stop reproducing it every time 😄 What do you think?

from snabbdom-to-html.

Yeah, that probably couldn't hurt
I really just borrowed yours, as it was much better than mine 😉

from snabbdom-to-html.

I'll do it then… haha I lifted it from virtual-dom myself as you propably noticed 😄

from snabbdom-to-html.

Open-source FTW! 🔥

from snabbdom-to-html.