cycle_client no longer works in a hook about penrose HOT 6 CLOSED

Are you able to give me the hash that this was last working on? It would also really help if you can put some logging into your hook and determine exactly when it is exiting. Looking over the code you have provided there are quite a few places where you could be exiting early.

from penrose.

from penrose.

@crypt17 I've rewritten your hook a bit to make it easier to reason about and added some simple print logging to trace the execution:

struct RmClientHook {}
impl Hook for RmClientHook {
    fn remove_client(&mut self, wm: &mut WindowManager, _: WinId) {
        if let Some(ws) = wm.workspace(&Selector::Focused) {
            println!("have focused workspace: {}", ws.name());
            if ws.len() > 1 {
                println!("more than one client (n={})", ws.len());
                let last = wm.client(&Selector::Index(ws.len() - 1));
                if last != wm.client(&Selector::Focused) {
                    println!("new focused is not last");
                    wm.cycle_client(Backward);
                }
            }
        }
    }
}

From what I can see, this is firing (yours was as well) and cycle_client is being called. cycle_client is also doing the right thing. When using a layout that does not trigger on a focus change it works fine but it results in an infinite loop of cycling clients for the example paper layout config. Working around that is something that you'll need to handle in your hook if this is how you are wanting to implement it.

from penrose.

from penrose.

from penrose.

This behaviour is a breaking change for layouts that follow focus. It will not be added to core. If you want to implement it as am extension as already discussed then feel free to do so.

from penrose.