Support for newer node versions about titaniumifier HOT 6 CLOSED

@Astrovic @ULSashido please use version 1.5.2. I briefly tested them on node 12 and 14, and tests passed.

from titaniumifier.

Having same issue, I assume the bluebird npm needs a newer version

from titaniumifier.

As you can see it has nothing to do with Bluebird (which is just the Promises implementation) but with adm-zip:

/…/titaniumifier/node_modules/adm-zip/headers/entryHeader.js:216:18
                              ^^^^^^^

There’s a relatively easy solution, that is to upgrade adm-zip to the latest 0.5.x version. Everything should work (tests are passing on my machine). @Robbe92 Can you take care of it?

from titaniumifier.

This is what is required to make tests pass.

diff --git a/package.json b/package.json
index e6f560d..f4e35be 100644
--- a/package.json
+++ b/package.json
@@ -30,7 +30,7 @@
     "analysis"
   ],
   "dependencies": {
-    "adm-zip": "0.4.7",
+    "adm-zip": "0.5.9",
     "bluebird": "^2.5.1",
     "browserify": "^11.0.1",
     "commander": "^2.5.1",
@@ -50,12 +50,14 @@
   },
   "devDependencies": {
     "grunt": "^0.4.2",
+    "grunt-cli": "^0.1.13",
     "grunt-contrib-clean": "^0.6.0",
     "grunt-contrib-jshint": "^0.11.2",
     "grunt-mocha-test": "^0.12.4",
     "grunt-titanium": "^0.3.1",
     "grunt-zip": "^0.17.0",
     "longjohn": "^0.2.4",
+    "mocha": "^1.20.0",
     "moment": "^2.5.1",
     "reduce": "^1.0.1",
     "reduce-component": "^1.0.1",

from titaniumifier.

(By the way adding grunt-cli and mocha is required because both npm and Yarn nowadays do not install peer dependencies automatically for you)

from titaniumifier.

Thanks a lot @yuchi!

from titaniumifier.