Comments (2)
Hi,
When implementing object oriented programming, as we are in this SDK, it is typically good practice to make all members private so long as they do not need to be public or protected, as is the case here. This improves code readability, and ensures that such members can only be changed and fetched deliberately and through the proper methods. I would recommend looking into OOP (object oriented programming) documentation for a more detailed explanation on the use of private as opposed to public. For these reasons, we are not planning on changing the SDK to use POPOs.
from smartystreets-php-sdk.
"When implementing object oriented programming, as we are in this SDK, it is typically good practice to make all members private so long as they do not need to be public or protected, as is the case here."
No, it's not. You have to understand the PURPOSE of this API, as opposed to spouting non-sense about object oriented programming. Users want to fetch data from your API, and access the information in a straightforward way. By making the returned objects private, you overcomplicate accessing the information. The PURPOSE of making objects private is to protect their information from manipulation by other objects in code. But the purpose of your API is to return information and make it easily accessible in code. If the users want to make methods or properties private, let them do that themselves. You are just overcomplicating the retrieval of data by making users access the data through specific public methods, which has no functional purpose in a system meant for easy data retrieval.
from smartystreets-php-sdk.
Related Issues (20)
- Improper use of count() on string HOT 1
- Bug: Use of undefined constant STDERR
- International Address could use Batch Service. HOT 1
- US Lookup get Json Response HOT 1
- PHP example using php curl
- getResult() returns array, not an object HOT 1
- Add status code to thrown exceptions HOT 1
- Does the PHPUnit executable need to be checked in? HOT 1
- CORS Issue
- [CRITICAL] Constant GEOLOCATE_TYPE_CITY already defined HOT 1
- Please do not return null as the fall through condition for Curl responses HOT 2
- Found one compatibiliy issue with PHP8.1 HOT 1
- StatusCodeSender.php variable $errorMessage undefined HOT 2
- Verify the same address in the official website tool, but fail in the SDK HOT 1
- [4.19.1] SDK should never be printing/echoing data HOT 3
- [4.19.1] US Autocomplete Pro `GEOLOCATE_TYPE_NONE` constant should be `"none"`, not `null` HOT 2
- Credentials validations HOT 1
- [5.0.1] New `withXForwardedFor` autocomplete builder method results in incorrect HTTP header HOT 2
- VERSION constant not namespaced HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smartystreets-php-sdk.