Update PHP SDK to use POPOs about smartystreets-php-sdk HOT 2 CLOSED

Hi,

When implementing object oriented programming, as we are in this SDK, it is typically good practice to make all members private so long as they do not need to be public or protected, as is the case here. This improves code readability, and ensures that such members can only be changed and fetched deliberately and through the proper methods. I would recommend looking into OOP (object oriented programming) documentation for a more detailed explanation on the use of private as opposed to public. For these reasons, we are not planning on changing the SDK to use POPOs.

from smartystreets-php-sdk.

"When implementing object oriented programming, as we are in this SDK, it is typically good practice to make all members private so long as they do not need to be public or protected, as is the case here."

No, it's not. You have to understand the PURPOSE of this API, as opposed to spouting non-sense about object oriented programming. Users want to fetch data from your API, and access the information in a straightforward way. By making the returned objects private, you overcomplicate accessing the information. The PURPOSE of making objects private is to protect their information from manipulation by other objects in code. But the purpose of your API is to return information and make it easily accessible in code. If the users want to make methods or properties private, let them do that themselves. You are just overcomplicating the retrieval of data by making users access the data through specific public methods, which has no functional purpose in a system meant for easy data retrieval.

from smartystreets-php-sdk.