Are tests running twice for each save? about goconvey HOT 8 CLOSED

You're not crazy, I've seen this too @mholt. Either it's a server bug or sublime is touching the file multiple times per save...

from goconvey.

@mholt @joliver Ok, this may sound crazy but I think I've figured this out and it has nothing to do with the server code. Open the keyboard settings in "System Preferences" and move the "Key Repeat" slider to "Off". Then start up your server and save a watched file several times (using Command-S), leaving a break between saves long enough for the tests to complete. Then move the slider to "Fast" and go back to the terminal and save the watched file (again with the keyboard shortcut). I've noticed that if I linger on that command even for the slighted amount of time I get two file events and therefore two save operations which result in two separate test runs. But this only happens when I have Key Repeat enabled. I've also saved several times using the mouse to select "Save" from the menu and have never seen two saves in succession. I'd love to see if you get the same behavior with the settings I've described. If we can verify this then I probably need to add a delay in which events are just ignored (which is what I thought the code was doing) to get around this issue because I like my key repeat very fast...

from goconvey.

Remember when I ran touch somefile?
On Oct 22, 2013 9:38 PM, "Michael Whatcott" [email protected]
wrote:

@mholt https://github.com/mholt @joliver https://github.com/joliverOk, this may sound crazy but I think I've figured this out and it has
nothing to do with the server code. Open the keyboard settings in "System
Preferences" and move the "Key Repeat" slider to "Off". Then start up your
server and save a watched file several times (using Command-S), leaving a
break between saves long enough for the tests to complete. Then move the
slider to "Fast" and go back to the terminal and save the watched file
(again with the keyboard shortcut). I've noticed that if I linger on that
command even for the slighted amount of time I get two file events and
therefore two save operations which result in two separate test runs. But
this only happens when I have Key Repeat enabled. I've also saved several
times using the mouse to select "Save" from the menu and have never seen
two saves in succession. I'd love to see if you g et the same behavior with
the settings I've described. If we can verify this then I probably need to
add a delay in which events are just ignored (which is what I thought the
code was doing) to get around this issue because I like my key repeat very
fast...
[image: screen shot 2013-10-22 at 9 35 57 pm]https://f.cloud.github.com/assets/202910/1387382/3edae006-3b94-11e3-9597-8661600028a8.png

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-26878400
.

from goconvey.

@joliver oh yeah... hmmm...

from goconvey.

@joliver I'm not seeing that right now. touch results in one save only for me.

from goconvey.

@joliver Wait, I just realized that I had modified the code for my tests, I may have found the bug...

from goconvey.

Alas, I can't figure out why sometimes I get single saves and sometimes I get doubles. I'll have this solved in the rewrite of the server...

from goconvey.

@mholt @joliver Hooray! Fixed! 137ac0a

from goconvey.