Scripts failing SILENTLY when there is a problem. about smack HOT 4 CLOSED

I guess we should simply exit with some reasonable error message when something like this happens. Yes?

from smack.

Well I think there are two things: (1) signaling a problem, and (2) trying to report what/why. At the very least, we should do (1) with sys.exit(X) with some non-zero X, or raise some exception -- I'm no python expert so I don't know what's more appropriate. We could then augment this with some message to address (2), for a less minimal solution. At any rate, these sorts of problems should propagate themselves all the way up though all wrapper scripts.

from smack.

Exiting with a nice error message seems to be the appropriate solution for our relatively simple scripts. I will implement this when I get a chance.

from smack.

Perhaps something like the following would work well -- here p = subprocess.Popen(..)

if p.returncode != 0:
  print >> sys.stderr, "LLVM/SMACK encountered an error:"
  print >> sys.stderr, output[0:1000], "... (output truncated)"
  sys.exit("LLVM/SMACK returned %s" % p.returncode)

Which would kill whichever script is running while spitting out a bit of the problem.

from smack.