Support for different SLO time windows about sloth HOT 7 CLOSED

I think, from my limited experience with SLOs, when it comes to choose one rolling window you either go with 30 days or with 28 days. Both seem to be valid and you can find examples of both outside in the world. For us 28 days kind of make sense being it 4 weeks and it seemed easy to reason about.

I don't think it would be the end of the world if we had to use 30d but if it is an easy addition having sane defaults that can be configured seems reasonable.

As to which part, I think it would be everything :)

from sloth.

We are looking at this with interest. Our existing SLOs are all defined with a 28d window, and there would be some disruption etc to change them. I agree with having simple defaults. Perhaps an enum here rather than a numeric figure would avoid too much complexity and bad behaviour sneaking in.

from sloth.

Hey @dsolsona!

thanks for the kind words, this motivates me a lot.

It was intended to set a default Window of 30d. The purpose of Sloth is to work for the majority of the people in the simplest way, this implies discarding lots of knobs and settings.

Could you explain to me your use case? (as a matter of gathering more information for the feature). For example what windows would you like? why? you would be interested only in the visual part (e.g: Grafana dashboard)? or other aspects like reporting, alerting... all?

Thanks for the issue!

from sloth.

I'll think about it, maybe makes sense to have a small setting for the windows mainly for special cases (and defaulting for 30d like now).

I'll let open the issue for now until we make a decision on this.

Thanks for the info!

from sloth.

Hi @dsolsona @rbtcollins!

I added support for customizing windows (in #182 and #180), I wanted to keep it simple, for now, Sloth only allows using 30 and 28 day time windows. You can use it with the new flag that was added to Sloth --window-days by default 30.

Could you help me test this feature, please? 😄 You have a docker image (before I cut a new release, I would like to grab your feedback first if it is possible):

docker run --rm -it  slok/sloth:6e950ad0b27bda6922709d2b4b6d93630f53f6ac --help

Many thanks!

from sloth.

@slok we're not using it yet, please don't wait for a test result from us.

from sloth.

Thanks for the reply @rbtcollins!

No problem, yesterday I released v0.8.0, so you can test whenever you want and raise a new issue if you want!

from sloth.