Giter Club home page Giter Club logo

Comments (4)

dpc avatar dpc commented on July 26, 2024 1

I'll try to look into it later today then.

from slog.

dpc avatar dpc commented on July 26, 2024

How was this undiscovered for so long? :D

slog/src/lib.rs

Line 422 in f9e30f0

(@ $args_ready:expr; $k:expr => #$v:expr) => {

this case needs to duplicated with , $($args:tt)* part, just like other forms.

Care do crate a PR with a test + fix? :)

from slog.

dpc avatar dpc commented on July 26, 2024

Oh, and slog_kv

slog/src/lib.rs

Line 475 in f9e30f0

(@ $args_ready:expr; $k:expr => $v:expr) => {
is supposed to be an exact copy of kv (just with a different name in case of a collision), but I can already see they are differences.

These macros used to be much simpler, and don't really scale well as contributors add new cases. 🤷

from slog.

lilyball avatar lilyball commented on July 26, 2024

Probably because the log macros don’t bother to document this feature, so most people are unlikely to be using it. I only found it by looking at ErrorValue, seeing the reference to this feature, and looked at the macro implementation to confirm.

I am not able to write any PRs at this time.

from slog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.