Giter Club home page Giter Club logo

Comments (2)

jamesobutler avatar jamesobutler commented on June 15, 2024

Thanks for the information.

If you already have a pinned numpy version in Slicer builds, then you have no issues until next release, but users must be warned not to upgrade numpy in any way.

Slicer does indeed pin the numpy version as part of the build process. Iā€™m sure if users post about problems on the discourse forum we can ask and recommend to not use numpy 2 if it is not compatible with Slicer yet.

# [numpy]
# Hashes correspond to the following packages:
# - numpy-1.25.1-cp39-cp39-macosx_10_9_x86_64.whl
# - numpy-1.25.1-cp39-cp39-macosx_11_0_arm64.whl
# - numpy-1.25.1-cp39-cp39-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
# - numpy-1.25.1-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
# - numpy-1.25.1-cp39-cp39-musllinux_1_1_x86_64.whl
# - numpy-1.25.1-cp39-cp39-win_amd64.whl
numpy==1.25.1 --hash=sha256:3d7abcdd85aea3e6cdddb59af2350c7ab1ed764397f8eec97a038ad244d2d105 \
--hash=sha256:1a180429394f81c7933634ae49b37b472d343cccb5bb0c4a575ac8bbc433722f \
--hash=sha256:d412c1697c3853c6fc3cb9751b4915859c7afe6a277c2bf00acf287d56c4e625 \
--hash=sha256:20e1266411120a4f16fad8efa8e0454d21d00b8c7cee5b5ccad7565d95eb42dd \
--hash=sha256:f76aebc3358ade9eacf9bc2bb8ae589863a4f911611694103af05346637df1b7 \
--hash=sha256:1d5d3c68e443c90b38fdf8ef40e60e2538a27548b39b12b73132456847f4b631
# [/numpy]

Therefore, you shall block numpy upgrades in the pip_install function.

This could potentially be done if numpy is specified directly, however it would not cover all cases if say a user specifies to install some other package that happens to depend on numpy where that package may specify numpy >= 2. Slicer pip_install is not going to know about various python package dependencies.

from slicer.

lassoan avatar lassoan commented on June 15, 2024

If numpy maintainers do this right, making changes gradually (using deprecation warnings for several years before any breaking change takes effect) then the transition will be smooth. No packages will require numpy 2.x until all other packages already support numpy 2.x. In this case we will not need to do anything special in Slicer, just find a safe time to update Slicer's numpy to 2.x.

If numpy developers mess up the transition and there will be a time when many packages still only support numpy 1.x while some already require numpy 2.x then we'll see what we need to do, but I'm optimistic that numpy developers are smart enough to avoid this.

from slicer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.