[2.1.7, 2.1.8, Git `master`] Plugin `smartpause` calls `disable_safeeyes` with unsupported signature, causing display of a backtrace about safeeyes HOT 9 CLOSED

Oh, I actually ran into this issue in #576 - the first commit there (7c241f1) contains a fix. I will pull it out into a separate PR today in the evening.

from safeeyes.

I have a fix up in #582. It would be good if you could test it, and confirm it resolves the issue.

from safeeyes.

Is this issue present in releases with python 3.12? Or is it python version independent. For maximum stability, I am planning to only include the new version of safe eyes (2.1.8 or later) for Ubuntu 24.04 or later. For previous versions of Ubuntu, Safe Eyes is already available on the official repositories.

from safeeyes.

How to reproduce this crash?

from safeeyes.

I ran safeeyes in terminal in Kubuntu 24.04, and when I enable smartpause, safeeyes prints the following in the terminal, but it does not crash.

screen saver extension not supported

I am using KDE 5.27 with Wayland.

from safeeyes.

I ran safeeyes in terminal in Kubuntu 24.04, and when I enable smartpause, safeeyes prints the following in the terminal, but it does not crash.

screen saver extension not supported

I am using KDE 5.27 with Wayland.

This needs to be tested on either GNOME or Sway Wayland, or on X11 - KDE Wayland currently does not support smartpause at all, really. (It uses xprintidle, which ends up always being idle, effectively.)
This is what I am trying to fix in #576.

(The message about screen saver not supported is unrelated, it's from the Do Not Disturb plugin.)

from safeeyes.

How to reproduce this crash?

@archisman-panigrahi quoting myself from above:

To Reproduce Steps to reproduce the behavior:

1. Install 2.1.8

2. Run safeeyes from the terminal

3. Wait a bit

4. See the backtrace above

The smartpause plug-in needs to be enabled of course. And I think not doing anything else in that time helps if the plugin wants to disable SafeEyes only when the machine is idle. My understanding of the plugin is superficial at the moment, though.

from safeeyes.

Oh, I actually ran into this issue in #576 - the first commit there (7c241f1) contains a fix. I will pull it out into a separate PR today in the evening.

@deltragon cool, thank you!

from safeeyes.

Sorry for creating the problem and not responding earlier. I have only just found time to come back to safeeyes and I'm glad that someone has fixed it many thanks.

from safeeyes.