Implement linting about zdravniki HOT 9 OPEN

I would suggest to merge the current lintig PR now. Afterwards we can turn the remaining rules ON one by one and create pull requests for those separately so we don't introduce too many changes in one shot.

from zdravniki.

merged #47, #60, #61. Everything still works 🎉

from zdravniki.

I've made a PR for no-underscore-dangle (#80) AND I have turned on the warnings for the remaining two, so at least you get some info when adding new features.

I would be in favour of enabling them and fixing them (I can do it) as they are improving the overall code quality and stability.

from zdravniki.

As long as the builds won't be failing after #47 is merged, then continue with smaller PRs, enabling additional rules and fixing the code as required.

from zdravniki.

By "builds won't be failing" you mean Docker image still build or something else @stefanb ? I have run the docker build and it works just fine. Also, I haven't really made any changes to the current build process but rather introduced a new git action that only runs on PRs being opened/updated.

from zdravniki.

then i suggest we merge it asap!

from zdravniki.

Should we enable any other rules?

from zdravniki.

Should we enable any other rules?

I don't think it's good idea. Some changes based on rules might require changes all over the code.

What I did is that I turned them on and try to fix specific file, component or just part of the code.
I did it here.

To run eslint for specific file just run in terminal yarn eslint path/to/file.

Be careful and don't commit .eslintrc with rules turned on.

from zdravniki.

@mihaerzen You beat me on no-underscore-dangle I was just heading to solve it when I noticed your PR.

One more thing. I have never written tests for react. Can you do one or two as examples?

from zdravniki.