Giter Club home page Giter Club logo

Comments (1)

slburson avatar slburson commented on May 26, 2024

I've decided to consider this a bug, and go ahead and fix it. There is, admittedly, a possibility that someone out there is depending on the current behavior, possibly inadvertently, but I think the odds are minuscule. The most common reason for testing equality on collections is when placing them in sets or using them as map keys, which in my experience is a very rare thing to do with maps; I'm not sure I've ever seen it. With seqs, it might be slightly less rare, but I expect it's quite a bit rarer to use defaults on seqs than on maps. So the most likely scenario in which this change would break your code would be where

  • you are using maps or seqs as set elements or map keys
  • you are giving them defaults
  • you are giving different instances different defaults
  • but, you are depending on those different defaults not mattering for the set or map lookup

Each of these is unlikely, and the product of four small probabilities is extremely small.

from fset.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.