Comments (1)
I've decided to consider this a bug, and go ahead and fix it. There is, admittedly, a possibility that someone out there is depending on the current behavior, possibly inadvertently, but I think the odds are minuscule. The most common reason for testing equality on collections is when placing them in sets or using them as map keys, which in my experience is a very rare thing to do with maps; I'm not sure I've ever seen it. With seqs, it might be slightly less rare, but I expect it's quite a bit rarer to use defaults on seqs than on maps. So the most likely scenario in which this change would break your code would be where
- you are using maps or seqs as set elements or map keys
- you are giving them defaults
- you are giving different instances different defaults
- but, you are depending on those different defaults not mattering for the set or map lookup
Each of these is unlikely, and the product of four small probabilities is extremely small.
from fset.
Related Issues (20)
- count-if and count-if-not return nil HOT 2
- Readme mentions FSet project page on common-lisp.net but it is not available HOT 1
- `@` only with function argument
- build order issues HOT 1
- Second value for `lookup` on sequences
- Faulty map lookup/building
- @ operator with symbol as first argument
- intersection on relations is bugged HOT 1
- style-warning: FSET:ITERATOR clobbers an earlier FTYPE proclamation HOT 2
- a few function shadowed but not exported HOT 1
- Add iterate extensions for fset types
- Review test suite for completeness HOT 1
- Tuple test should be multithreaded
- Need tests for CL compatibility functions HOT 2
- Reversing a char-containing sequence doesn't work
- map syntax too complicated HOT 1
- Tests failed on ECL, Clisp and ABCL HOT 2
- Duplicate 'inline' declarations
- Get rid of cartesian product construction
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fset.