Giter Club home page Giter Club logo

Comments (1)

slawlor avatar slawlor commented on September 16, 2024 3

This is awesome! I don't think the implementation looks that janky actually, I understand the implementation requirements around JoinHandle but that could be cleaned up relatively easily I think (that's probably quite tokio specific tbh).

Tokio's default I/O channels (tokio::sync::mpsc, etc) are all runtime independent and I'm glad they seem to work with in WASM.

One thing though, it looks like if we enable tracing, we're back onto the tokio runtime? I feel like maybe in WASM it would make sense to just ignore the tracing configuration bit and not spawn anything named (as it's really only a feature for tokio-console to assist identifying which tasks are which actors). Also 1 small nit, I wonder if it'd be better to utilize a shared macro or something if we're going to share implementations (i.e. the select! statement in your wasm_primatives module).

Does everything work as expected? The tests all pass on a WASM runtime? You can also try out the examples and benchmarks to see how it does!

If we clean it up a bit, this would be a great PR :)

from ractor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.