Giter Club home page Giter Club logo

Comments (1)

filmaj avatar filmaj commented on June 27, 2024

Great suggestion, and we would happily take you up on the offer to send a PR for this 🙇 ❤️

Taking a brief look, here is how I would approach an implementation, but this is only a suggestion:

  1. Copy the HTTPReceiver's approach of tracking a signatureVerification boolean in the class, which can be set using the constructor.
  2. The AwsLambdaReceiver's toHandler method outputs a function that is what will be invoked at runtime on the Lambda. Within this method there is a section that today executes signature verification every time.
  3. Modify this section to check for the value of the newly-added signatureVerification boolean before executing any verification.
  4. Add any tests covering the new functionality.

I think that would be sufficient! Happy to review any PRs or answer any other questions about this anyone may have.

from bolt-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.