Comments (6)
Hi @NimaSoroush - thanks for reporting this!
This may be due to the app thinking you are dragging rather than clicking, which sometimes happens with high-precision input devices such as Wacom Bamboos. Would you mind telling us what pointing device you are using?
If this is what's happening then maybe we should update our check to discount a "drag" action if it is over a very short distance. Will have a think 😸
from backpack.
Hi @georgegillams
I can actually reproduce it on my Mac machine with chrome and firefox. I am definitely not dragging. I just quickly click outside of modal box. If I do it slowly the modal will close. My though is that some kind of asynchronous initialization happening which causes this.
from backpack.
Hmm.. I don't seem to be able to reproduce this in either browser on macOS. I've tried using Auto Mouse Click to perform the click in 1ms, and it works fine.
Do you mind providing more details about your system?
from backpack.
Also just to let you know our documentation has moved to https://backpack.github.io/components/web/modals/ and the link you provided redirects, but I can't see that making any difference
from backpack.
@georgegillams : Here is the video of reproducing it
https://screencast.com/t/c3tdsimsKgI
from backpack.
Hey @NimaSoroush - I think we may have now fixed this issue (although we haven't yet released the changes). You can test the change here https://backpack.github.io/components/web/modals/ and https://backpack.github.io/components/web/dialogs/
If you're happy with the fix, go ahead and update you dependency!
https://github.com/Skyscanner/backpack/blob/master/changelog.md#2018-02-16---fixed-mouse-clicks-not-always-closing-modals-and-dialogs
Happy to reopen this if you don't think we have resolved your issue.
Thanks again for raising this!
from backpack.
Related Issues (20)
- An in-range update of husky is breaking the build 🚨 HOT 1
- An in-range update of react-slider is breaking the build 🚨
- An in-range update of eslint_d is breaking the build 🚨 HOT 1
- An in-range update of babel7 is breaking the build 🚨 HOT 1
- An in-range update of yaml is breaking the build 🚨 HOT 1
- [bpk-component-datepicker] /bpk-component-calendar/src/BpkCalendarContainer.js: Support for the experimental syntax 'classProperties' isn't currently enabled (102:21) HOT 1
- Support projects not using scss HOT 2
- [bpk-component-horizontal-nav]/[bpk-mixins] using incompatible shadow styles for React Native HOT 3
- Test HOT 1
- Split of React Native and React components? HOT 3
- Start using react 17 HOT 3
- No bpk-component-switch in the readme? HOT 2
- Error while installing calendar component HOT 1
- Add React.forwardRef to enable ref in BpkButton?
- [feature request] Add holiday highlight in bpk-calendar HOT 2
- problem with typing in BpkButton.js HOT 17
- SyntaxError: Unexpected token 'export' HOT 2
- Mini StackBlitz (or similar) demo request HOT 6
- Extract the in Web UI price of individual fligths when there's 1 or multiple stops HOT 2
- "Sass Loader Error: <Brief Description>" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backpack.