Giter Club home page Giter Club logo

Comments (6)

georgegillams avatar georgegillams commented on August 14, 2024

Hi @NimaSoroush - thanks for reporting this!
This may be due to the app thinking you are dragging rather than clicking, which sometimes happens with high-precision input devices such as Wacom Bamboos. Would you mind telling us what pointing device you are using?
If this is what's happening then maybe we should update our check to discount a "drag" action if it is over a very short distance. Will have a think 😸

from backpack.

NimaSoroush avatar NimaSoroush commented on August 14, 2024

Hi @georgegillams
I can actually reproduce it on my Mac machine with chrome and firefox. I am definitely not dragging. I just quickly click outside of modal box. If I do it slowly the modal will close. My though is that some kind of asynchronous initialization happening which causes this.

from backpack.

georgegillams avatar georgegillams commented on August 14, 2024

Hmm.. I don't seem to be able to reproduce this in either browser on macOS. I've tried using Auto Mouse Click to perform the click in 1ms, and it works fine.

Do you mind providing more details about your system?

from backpack.

georgegillams avatar georgegillams commented on August 14, 2024

Also just to let you know our documentation has moved to https://backpack.github.io/components/web/modals/ and the link you provided redirects, but I can't see that making any difference

from backpack.

NimaSoroush avatar NimaSoroush commented on August 14, 2024

@georgegillams : Here is the video of reproducing it
https://screencast.com/t/c3tdsimsKgI

and system detail:
2017-12-08_1353

from backpack.

georgegillams avatar georgegillams commented on August 14, 2024

Hey @NimaSoroush - I think we may have now fixed this issue (although we haven't yet released the changes). You can test the change here https://backpack.github.io/components/web/modals/ and https://backpack.github.io/components/web/dialogs/

If you're happy with the fix, go ahead and update you dependency!
https://github.com/Skyscanner/backpack/blob/master/changelog.md#2018-02-16---fixed-mouse-clicks-not-always-closing-modals-and-dialogs

Happy to reopen this if you don't think we have resolved your issue.
Thanks again for raising this!

from backpack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.