Build error with vs2019 about uvw HOT 19 CLOSED

Good to know, but what can I do with a compiler bug I cannot even reproduce?

First I would say, report it, AFAIK the MSVC team would appreciate such feedback.
Meanwhile I'll try to figure out a workaround.

I have tried to report it here.

from uvw.

UVW Compiles successfully in the latest Visual Studio update 16.3.4

from uvw.

I've just run the sample code, it does fail with cl 19.21.27619.1 (a.k.a 16.1.0 Preview 3) but works just fine with 19.20.27508.1 (a.k.a. 16.0.3), so I'd say it's most likely a compiler bug.
Bug could be either that it compiles with 19.20 or that it fails with 19.21, as I'd expect code to compile the same for a semver-minor version change.

from uvw.

So, it's confirmed that the bug is in VS, right?
I'll mark the issue as won't fix. Please, close it when the fix is upstream.
Thanks.

from uvw.

No idea @Merethiel - I'm not using Windows and this problem doesn't really depend on me, so I cannot do much.
The issue is open only to track it and avoid duplicates but you should rather ask MS when they plan to accept valid C++ with their compiler.

from uvw.

Here are my pch.h, I don't think there are any incompatible headers:

#define _SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING
#ifndef PCH_H
#define PCH_H

// add headers that you want to pre-compile here
#include <uvw.hpp>
#include <string>
#include <rapidjson/document.h>
#include <rapidjson/writer.h>
#include <rapidjson/stringbuffer.h>
#include <list>
#include <iostream>
#include <mysql.h>
#include <vector>
#include "user.h"
#include "Word.h"
#include "md5.h"
#endif //PCH_H

from uvw.

Can you make a small, reproducible example I can run for my own?
Otherwise I don't know how to reproduce it and I cannot look into the problem.

from uvw.

Here comes the sample which are copied from README.md.
I tried to compile it on my computer and get this:

from uvw.

Side question: have you tried them without pch stuff?
Currently all tests pass without problems on appveyor with the last vs, so it's likely that the problem is the pch itself.
This question just to confirm it.

from uvw.

Good to know, but what can I do with a compiler bug I cannot even reproduce?
If you know of a workaround for this, I'm open to suggestions.

from uvw.

Good to know, but what can I do with a compiler bug I cannot even reproduce?

First I would say, report it, AFAIK the MSVC team would appreciate such feedback.
Meanwhile I'll try to figure out a workaround.

from uvw.

Peijie Chen [MSFT] :
A fix for this issue has been internally implemented and is being prepared for release16.3. We'll update you once it becomes available for download.

It seems that it will be fixed in 16.3

from uvw.

I wasn't able to find a reasonable workaround ¯\(ツ)/¯ (code-wise)

from uvw.

FTR:

• v16.1.0 (i.e. CL 19.21.27702.2) - ❌
• v16.2.0 preview-1 (i.e. CL 19.22.27706.1) - ❌
• v16.0.3 (19.20.27508.1) - ✔️

from uvw.

I wasn't able to find a reasonable workaround ¯_(ツ)_/¯ (code-wise)

Don't worry, I failed as well. Being it an issue with the compiler, it makes sense anyway to wait for them to solve it. 👍
Thank you for your help. Really appreciated.

from uvw.

I have this bug (with or without /Zc:twoPhase-, /permissive-) at:

• v16.3.0 VS2019 Preview
• v16.2.4 VS2019
• v15.9.15 VS2017

from uvw.

They claim that a fix is available for VS2019. Time to close this issue?
Since it's a bug in VS, I cannot do much anyway.

from uvw.

I was receieving the same error in VS 2019. @skypjack I do have the most updated version of VS currently do you know if the update for the fix has been rolled out already because mine still has those same compiler errors.

from uvw.

That's great @JadeVand thanks for pointing it out. Time to close this issue. 😉

from uvw.