Comments (14)
F-Droid maintainer here. Thanks for chiming in, @skydoves! We'd need metadata (app description, summary, screenshots etc) in a Fastlane structure β and versionCode
plus versionName
as literals (not variables or function calls) in build.gradle
(which is also important to automatically detect new versions).
from pokedex.
@skydoves could you please fix this?
from pokedex.
Hey @airon90, Sorry for the late reply.
As following the comments, F-Droid can't recognize metadata that is located in the dependencies.gradle
file right?
Then should I modify all of the references of the dependencies.gradle
to statically or can we deal with it just by modifying the versionCode
and versionName
?
from pokedex.
Hi @IzzySoft, thanks for the review. I just created a PR (#44) for integrating into the F-Droid, so could you please check the structure of the metadata is correct?
from pokedex.
versionName getVersionName()
won't work. versionName
and versionCode
(already is) must be literals β no variables or function calls, see above. Else updates won't be found (the F-Droid updater just uses RegEx to parse the gradle files, it doesn't execute them) and you'd need to create a merge request at fdroiddata vor each version, which is not a good idea π
Fastlane structure looks good β but short_description.txt
is too long. It will be truncated at 80 chars.
You might wish to place an icon.png
into metadata/en-US/images
(not mandatory, but helpful β especially in case your app uses only XML icons).
from pokedex.
Hi @yehezkiell,
I updated the metadata from your reviews! Could you please check about it again?
from pokedex.
Can anybody can tell me how you all have calculated the stats of pokemon. Can anybody can share the formula?
from pokedex.
Can anybody can tell me how you all have calculated the stats of pokemon. Can anybody can share the formula?
Here is link for for that :https://github.com/skydoves/Pokedex/blob/main/app/src/main/java/com/skydoves/pokedex/model/PokemonInfo.kt
Also always create new issue or add a commnet in related open issue
from pokedex.
What about the issue? @skydoves @IzzySoft
from pokedex.
Sorry @airon90 β I'm usually not working in the "games segment". I've just carried over the issues I saw reported at F-Droid so they can be addressed. The request there will be worked on by another team member.
from pokedex.
@skydoves Do you have updates?
from pokedex.
@inson1 see my comment just before yours: I don't work on games, so no need to ping me for updates on their progress π
from pokedex.
@IzzySoft sorry :)
from pokedex.
Huh? Eh, errβ¦ Sorry, too // as it wasn't you π
(I simply unsubscribe from notifications here then π)
from pokedex.
Related Issues (20)
- Dependency Dashboard
- App build failure by circular dependency between kapt and ksp HOT 1
- First letter should be capitalized
- 5 type arguments expected for interface CommonExtension in build.gradle.kts HOT 1
- Just a little Typo on your core-data module
- Unnecessary provides function for DetailRepository HOT 2
- how to refresh when page=0 HOT 1
- Why does the author define a blank interface in a project?
- # of Downloads?
- failed to load pokemon images HOT 2
- Repository Interface not used? HOT 2
- ListAdapter reset RecyclerView after submitList(Edit)->If you direclty fetch from the network and submit list that will cause this issue HOT 1
- Could you please add paging3
- ζΎδΈε°η¬¦ε· hilt注解ηΌθ―ζΆ
- Responsive Font size
- Responsive dimensions
- Overwrite character "-" in names to " " HOT 2
- Add menu with About page HOT 2
- Add Pokemon number to Pokemons in Index page HOT 2
- Better Offline mode
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokedex.