Giter Club home page Giter Club logo

Comments (14)

IzzySoft avatar IzzySoft commented on May 18, 2024 2

F-Droid maintainer here. Thanks for chiming in, @skydoves! We'd need metadata (app description, summary, screenshots etc) in a Fastlane structure – and versionCode plus versionName as literals (not variables or function calls) in build.gradle (which is also important to automatically detect new versions).

from pokedex.

airon90 avatar airon90 commented on May 18, 2024 1

@skydoves could you please fix this?

from pokedex.

skydoves avatar skydoves commented on May 18, 2024

Hey @airon90, Sorry for the late reply.
As following the comments, F-Droid can't recognize metadata that is located in the dependencies.gradle file right?
Then should I modify all of the references of the dependencies.gradle to statically or can we deal with it just by modifying the versionCode and versionName?

from pokedex.

skydoves avatar skydoves commented on May 18, 2024

Hi @IzzySoft, thanks for the review. I just created a PR (#44) for integrating into the F-Droid, so could you please check the structure of the metadata is correct?

from pokedex.

IzzySoft avatar IzzySoft commented on May 18, 2024
versionName getVersionName()

won't work. versionName and versionCode (already is) must be literals – no variables or function calls, see above. Else updates won't be found (the F-Droid updater just uses RegEx to parse the gradle files, it doesn't execute them) and you'd need to create a merge request at fdroiddata vor each version, which is not a good idea πŸ˜‰

Fastlane structure looks good – but short_description.txt is too long. It will be truncated at 80 chars.

You might wish to place an icon.png into metadata/en-US/images (not mandatory, but helpful – especially in case your app uses only XML icons).

from pokedex.

skydoves avatar skydoves commented on May 18, 2024

Hi @yehezkiell,
I updated the metadata from your reviews! Could you please check about it again?

from pokedex.

souvikpal2000 avatar souvikpal2000 commented on May 18, 2024

Can anybody can tell me how you all have calculated the stats of pokemon. Can anybody can share the formula?

from pokedex.

AndroidPoet avatar AndroidPoet commented on May 18, 2024

Can anybody can tell me how you all have calculated the stats of pokemon. Can anybody can share the formula?

Here is link for for that :https://github.com/skydoves/Pokedex/blob/main/app/src/main/java/com/skydoves/pokedex/model/PokemonInfo.kt
Also always create new issue or add a commnet in related open issue

from pokedex.

airon90 avatar airon90 commented on May 18, 2024

What about the issue? @skydoves @IzzySoft

from pokedex.

IzzySoft avatar IzzySoft commented on May 18, 2024

Sorry @airon90 – I'm usually not working in the "games segment". I've just carried over the issues I saw reported at F-Droid so they can be addressed. The request there will be worked on by another team member.

from pokedex.

inson1 avatar inson1 commented on May 18, 2024

@skydoves Do you have updates?

from pokedex.

IzzySoft avatar IzzySoft commented on May 18, 2024

@inson1 see my comment just before yours: I don't work on games, so no need to ping me for updates on their progress πŸ˜‰

from pokedex.

inson1 avatar inson1 commented on May 18, 2024

@IzzySoft sorry :)

from pokedex.

IzzySoft avatar IzzySoft commented on May 18, 2024

Huh? Eh, err… Sorry, too // as it wasn't you πŸ™ˆ

(I simply unsubscribe from notifications here then πŸ˜‰)

from pokedex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.