Add member for getting the displayed path? about qpathedit HOT 4 CLOSED

You do have a point. I also just realised that this would change the way the path property would behave, and I would like to avoid that.

So instead, we could either:

1. Change the method to take an optional argument, as already suggested by you: QString QPathEdit::path(bool queryInvalid = false) const. This would not change default behaviour, since the argument is defaulted.
2. Add a new method for this purpouse: QString QPathEdit::editPath() const. This would return the path as currently visible in the text edit, no matter it's validity.

I personally would prefer the 2. variant, as we could keep binary compability this way. Also I personally think having two seperate methods makes it clearer how the result of the two could differ.

from qpathedit.

I totally agree with you. I would suggest a method like this: QString QPathEdit::path(bool *pathValid = nullptr) const. Feel free to create a pull request with that change if you want to get it done quickly.

from qpathedit.

Ok, but what is the point behind the pointer argument type? The validity of the returned path could be checked by checking the emptiness of the returned path or the bool hasAcceptableInput() method could be used for this purpose as well.

from qpathedit.

I prefer the 2. variant too, PR submitted.

from qpathedit.