`error-level` option does not work under `analyze` task about dart_pre_commit HOT 2 CLOSED

I tried to reproduce the issue, and I think the problem lies in how the tool handles analyzer results. Currently, it ignores the exit code and simply checks if lints are present. This was done to enable scan-mode: staged, as the analyzer tool itself cannot be instructed to only scan parts of the project. However, as it seems, it will still print out warning, even if they are marked as non fatal.

This leaves me with 2 options: Remove the error-level completely or remove the scan-mode completely, as we can't do both. I personally would tend more to removing the scan-mode, as it is already artificial (because not natively supported by the dart analyzer) and has led to problems in the past (as changes in staged code might be error free, but could very well cause problems in other files).

I will notify you, once the updated version was released.

from dart_pre_commit.

Version 5.3.0 with the fixes has been published

from dart_pre_commit.