Adding 'plugins' to user-defined webpack config produces incorrect build output for commands about skpm HOT 17 CLOSED

Just pushed template for skpm with TypeScript and TSLint here: https://github.com/romansp/skpm-typescript.
That was really easy to do. Thanks a lot for your efforts adding support for custom templates and skpm in general. 👍

from skpm.

My guess is that when multiple "script" files are run through 'webpack' userDefinedWebpackConfig.plugins becomes mutated.

oh yes, of course, silly me.

I'd love a PR yes, can you make sure it's compatible with node 6 (don't remember when [...] was introduced)?

from skpm.

@mathieudutour, while we are here, what do you think of similar support for webpack's module.rules or maybe even more stuff?

I'm currently using typescript and vue.js for Sketch plugin development and can't use skpm's preconfigured staticResourceLoader and babelLoader, as I'm overriding those completely with my own rules for loaders.

That's shouldn't be very hard to implement. Can do it in my spare time, if you find it useful.

from skpm.

I'm all for more support of custom webpack config. I was just a bit concerned that if I added to skpm rules to the custom rules, there would be some conflicts and that would be really hard to debug and understand for the user

from skpm.

Thinking a bit more about the webpack config: what do you think about having a special file webpack.config.skpm.js which should expose a function taking the default config as an argument? The user can do whatever they want with it and it's clear that if something breaks, it's their config so it's easier to debug and fix. (that's what preact is doing: https://github.com/developit/preact-cli#webpack)

from skpm.

That sounds good. I like it.

Want to share my current experience. At first, I was happily surprised that I can add webpack.config.js or .babelrc and it will go right into the skpm build process, so I can easily add support for typescript, vue, whatever. After I added rules and tried building I was pretty much confused of where did skpm rules go and why babel stopped doing its thing. It wasn't clear at all.

So, yeah I definitely like that approach more than the current. I'm also starting to think about dev/prod builds: tree shaking, minification, etc. With the approach of having a special file it will be easier to setup dev/prod builds, I guess at least.

I saw your comment mentioning that skpm is in the finished state and it definitely is, so I'm not quite sure if you are in the mood to implement new features. I like working with it anyway, but making some additional knobs will be a huge 👍.

from skpm.

I'm actually completely re-writing it to split the build process from everything because I don't want to bloat plugin with unnecessary stuff 😄
I'll see if I can integrate that during the rewrite

from skpm.

I'd love it if you could check out the new readmes before I merge 😄
https://github.com/skpm/skpm/blob/9c57129bd8e21ad9692e11611617db1920185dde/README.md
https://github.com/skpm/skpm/blob/4449179a278452a7ea23df531aa1e3a9ba68170e/template/README.md

from skpm.

Woaw, that was quick. Just looked through and it looks good to me. Also templating support is really cool stuff 👍.

from skpm.

If you are up to create a template for typescript, i’d happily linked to it :)

from skpm.

I would really like to do it. However my current setup is far from ideal, and I need to integrate recent changes to skpm first. Anyway, will try to find some time to contribute back :)

from skpm.

awesome! Do you think we could generate the sketch.d.ts from the class dump? 🤔

from skpm.

I was thinking about generation of sketch.d.ts automatically and maybe starting it as a next pet-project. Unfortunately, I'm out of ideas from where do I even start. If you have some thoughts I will be happy to discuss this.

For Sketch plugin that's currently in development I manually fill sketch.d.ts using class-dump as a reference. I also have globals.d.ts where I put things relevant to NS* and Mocha. But decided to keep template clean and didn't include it.

I already benefited a lot from doing types both for refactoring and overall development purposes. Of course it requires initial efforts, but I don't regret it at all.

from skpm.

it should be possible to parse a header file (something similar to this: https://github.com/subh007/ObjCParser) and then generate a types file from that object. A first step could be just getting the methods without the types of the arguments.

Probably won't have time to look into it just right now but maybe in a couple of weeks

from skpm.

Thanks for the link, that's the approach I'm thinking of. Will look into this particular tool (or maybe other alternatives) in my spare time. Will keep you updated, if there will be any progress 😄 .

from skpm.

We've got the headers parsed here https://github.com/skpm/sketch-headers if you want to use them to generate a typescript types file

from skpm.

Oh my, that's impressive! Great starting point for typescript generation. Will definitely use it. Thank you!

from skpm.