Comments (14)
yes, I fixed that when we were using rollup but switching to webpack broke it.
Can you tell me what is your use-case? I had one in mind specifically (onClick handler for react-sketchapp) but I'm curious if there is more
from skpm.
I have a handful of commands that I'm placing in the Sketch menu which are contextually similar, but call different methods (ex "Clear all guides", "Clear guides in artboard", "Clear horizontal guides", etc.) They're all effectively one liners into other methods so it seems gratuitous to put them all in their own separate files. I suppose one could argue that I make the whole thing a class and export that.
The last time I ran it, I was looking for a solution for syncing the current context with your sketch-web-view. I had two commands, one that launched the web view and one that was a listener for selection change events which would sync data into the html content of the webview. I ultimately opted for splitting them apart because they were different enough.
from skpm.
got it. I'll try to find a fix
from skpm.
No rush on my end. The hack works fine for me, but I figured I'd report it in case it's something you care about, and because it does make for some slightly unpredictable results.
from skpm.
I actually don't know how to do it. Is there any webpack expert around who have an idea?
from skpm.
For reference, here's the actual error in Console.app
ReferenceError: Can't find variable: exports.
Plugin “All artboard guides”, line 43:
» Object.defineProperty(exports, '__esModule', { value: true });
For giggles, I tried doing this:
var exports
export var foo = function (){}
export var bar = function (){}
export default function(){
exports
}
But that gets compiled in a way that gives exports
a new name so it doesn't clobber the actual exports
variable, which I suppose is good behavior.
I guess the only solution I can picture is something that just prepends var exports
to the file, but I'm not sure that's any better than my hack mentioned in the OP
from skpm.
thinking about this a bit more: would adding var exports
at the top of the file with a webpack plugin (https://webpack.js.org/plugins/banner-plugin/) make it work?
from skpm.
Hmm… interesting idea. I scrapped this project in favor of a cleaner solution, but I'll try this out once I get back to this stage.
from skpm.
I manage to do it here: 804046e
from skpm.
I can confirm it works 👍
from skpm.
That was quick! Thanks
from skpm.
@mathieudutour could you please bump the version and push to npm? 🤗
from skpm.
It's a breaking change, I'd like to get #44 in as well, and maybe fixing #45 before releasing
from skpm.
Ok, I can live with the github version, thanks!
from skpm.
Related Issues (20)
- skpm publish does not add or update lastUpdated flag in plugin directory HOT 5
- skpm-build --output: absolute paths are not supported
- Typescript bug: if I try use typescript file with .ts extension as a manifest script, build incorrectly replace the script name HOT 1
- Confused about skpm versions HOT 1
- Publishing on OSX Big Sur HOT 7
- Webpack 5
- skpm-build --watch doesn't update Sketch plugin folder HOT 2
- ssri vulnerability HOT 5
- Sass-loader not compatible with webpack version
- glob-parent vulnerability HOT 1
- Sketch crushes after trying to load a plugin HOT 1
- TextAlignment mistake on apple silicon HOT 1
- Cannot build project: TypeError: console.log.bind is not a function
- skpm breaking my plugin HOT 2
- null is not an object (evaluating 'NSApplication.sharedApplication().orderedDocuments().firstObject().showMessage') HOT 1
- How to notify in sketch after publishing?
- Builder is crashing because dependencies are old HOT 6
- [CVE-2023-0842] `xml2js` has vulnerability, needs updated
- Adding webbrowser api libraries to skpm puging
- one error with `babel-loader`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skpm.