Issues in braindecode recently introduced by skorch about skorch HOT 3 CLOSED

@bruAristimunha Thanks for reporting the issue. This sounds serious. We are always careful not to break backwards compatibility, and if we do are very explicit about it and provide a guide for upgrading. So this sounds like something slipped through.

I think the best way forward would be to identify the exact commit that broke your tests. That's probably best achieved by using git bisect. Let me know if you want to give it a try, I'll support as best as I can. Alternatively, if you could give me a small script (small in the sense that it runs fast) that fails with the current skorch version but worked previously, I can bisect on my own.

from skorch.

Hi @BenjaminBossan!

Thank you very much for opening this issue. I followed his recommendation, and it was unclear why we now need the classes parameter when we tested in Python version 3.8 or higher. I tried to follow the instructions and create a mini-code to deliver to you; however, as we are going to make a code sprint next week, I preferred to incorporate this new parameter into the examples in the braindecode rather than finding out exactly what generated this requirement.

From what I studied, it could even have been sklearn. The lesson has been learned, and we will improve the control of these dependecies. For me, we can close this issue, and I thank you for your immense work on skorch :)

from skorch.

From what I studied, it could even have been sklearn

This is very much possible. Actually, some skorch code also started failing because somewhere inside of sklearn, there was a change that suddenly required classes_ when previously it was not required. See this comment:

It seems that the classes_ attribute is now required on classifiers for some stuff related to sklearn scoring, where previously it wasn't

I also tried to figure out the exact change but then gave up and just accepted it.

I thank you for your immense work on skorch :)

Thanks a lot, always happy to hear it.

from skorch.