Comments (6)
Hi @jatubio .
Can you please try this regular expression the affected routes?
It will support spanish letters and accents, and in my testing it seem to pass on the routes you have issues with.
SimpleRouter::get('cursos/listado/{listado?}/{filtro?}', $callback, ['defaultParameterRegex' => '[\w\p{L}\s-]+']);
No worries - I always appreciate feedback which helps improve the project, so keep em' coming 👍
Let me know if the above works.
/ Simon
from simple-php-router.
I'm glad to hear. I'll close this issue.
/ Simon
from simple-php-router.
Hi @jatubio .
I will make some unit tests and see what I can do about the issue you are experiencing.
Until then you might be able to create your own workaround by defining your own regular expression for the parameters. By default the library uses only \w
which matches A-Z
, 0-9
and a limited set of special characters.
Please refer to the "Custom regex for matching parameters" section in the documentation for further information:
https://github.com/skipperbent/simple-php-router#custom-regex-for-matching-parameters
I think something like this could work (haven't tested):
[\w\%]+
I'll keep you posted when I've got further info.
/ Simon
from simple-php-router.
Hi @skipperbent.
I have tested the url /cursos/listado/especialidad/Cardiolog%C3%ADa
with SimpleRouter::('cursos/listado/{listado?}/{filtro?}', $callback, ['defaultParameterRegex' => '[\w\%]+'])
but it don't work.
Maybe this can help you:
- If i write
/cursos/listado/especialidad/Cardiolog%C3%ADa
, i get/cursos/listado/especialidad/Cardiología
on php logs. Then, maybe you can add/u
flag to parameter regex to support unicode letters.
But, it's not a complete solution because %20
for spaces.
Simon, Thank you for your time.
PS: If you think that it's too much work to solve this issue, I can change my code easily
to remove unicode characters and replace spaces with something like -
. The main reason for opening this issue has been to help you to improve the library
from simple-php-router.
Copy-pasta of passing unit-test:
public function testUnicodeCharacters()
{
TestRouter::get('/cursos/listado/{listado?}/{category?}', 'DummyController@method1', ['defaultParameterRegex' => '[\w\p{L}\s-]+']);
TestRouter::get('/kategori/økse', 'DummyController@method1', ['defaultParameterRegex' => '[\w\ø]+']);
TestRouter::debugNoReset('/cursos/listado/especialidad/cirugía local', 'get');
$this->assertEquals('/cursos/listado/{listado?}/{category?}/', TestRouter::router()->getRequest()->getLoadedRoute()->getUrl());
TestRouter::debugNoReset('/kategori/økse', 'get');
$this->assertEquals('/kategori/økse/', TestRouter::router()->getRequest()->getLoadedRoute()->getUrl());
TestRouter::router()->reset();
}
from simple-php-router.
Thank you @skipperbent, it works like a charm! :)
from simple-php-router.
Related Issues (20)
- Loaded route not available to middelware? HOT 1
- InputItem::offset returntype HOT 5
- Method of a controller does not receive the data by POST HOT 7
- Uncaught Pecee\SimpleRouter\Exceptions\NotFoundHttpException using Postman/Ajax HOT 3
- How to return a simple .php webpage? HOT 2
- Bad Request error when url's parameters contain "%" using regex HOT 2
- Bugs not displayed HOT 11
- PCEE inside a subfolder - Why is there need to put the sub folder as path can't we have it as Laravel does HOT 2
- PHP 8.1 Gives error DEPRECATED HOT 3
- 5.3.0.1 hides exception cause HOT 1
- LoadableRoute::setUrl() doesn't empty the parameter array
- How can I add before and after hooks to my Controllers? HOT 2
- Url params not working with Resource routes HOT 14
- Nested Resource routes HOT 1
- How can I get real exception instead of Router one? HOT 2
- Incorrect status code returned when catching an error using the SimpleRouter::error() function HOT 1
- How can I manipulate input values? HOT 1
- It throws an error when there is an unexpected value in the URL. HOT 1
- route HOT 3
- Unable to handle url-encoded and form-data request HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simple-php-router.