Button loses all Skeleton styling if disabled value changed when class property set about skeleton HOT 10 CLOSED

Thanks Neil, I'll take a look asap!

from skeleton.

Absolutely, good luck with it, looks great, I love sveltekit and tailwindcss so this project will be a godsend for internal tools etc. Thanks for all the work so far!

from skeleton.

FYI Neil, I've pushed a potential fix for this issue to my in-progress QA branch: d19ad67

I'm going to let Thomas, our resident QA expert, give this a once over before I consider this complete. If I was a betting man I'd expect this to see this in a release later this week though. Thanks for your patience in the meantime!

from skeleton.

@endigo9740 - Looking into this now.

from skeleton.

Confirmed this will be fixed by the merge of d19ad67...

from skeleton.

Sorry for the double post, but updating to 0.30.5 or later this issue should now be resolved for you:
https://github.com/Brain-Bones/skeleton/releases/tag/0.30.4
https://github.com/Brain-Bones/skeleton/releases/tag/0.30.5

from skeleton.

I've been able to replicate the issue on my end. Seems it's a side effect of our use of Svelte's $$restProps. This is a catch-all for miscellaneous properties so we don't have to specify every possible anchor or button attribute (ex: target, type, etc).

We experienced a similar issue that would occur on initialization of the component, but patched this in the last release. Unfortunately this fix doesn't extend to when a component prop updates, resulting in the unstyled component you're seeing.

I'm aware of about 5 components this bug may be affecting. I think it may be advisable for us to drop $$restProps and find another means to handle miscellaneous attributes. That or take the whitelist approach and build up over time.

Working on a couple other things this week, but I'll try to swing back to this as soon as I can. Thanks!

from skeleton.

Thanks for the kind words!

Making a note for myself for a potential fix:

• If we add class as a prop for any component then it won't be included restProps, which should be our fix.
• This will mean we have two types of props: always declared (props) and potentially declared (restProps)
• This will supersede the need for the delete fix from last patch

from skeleton.

Merged: #50

from skeleton.

Thanks that's great will give it a whirl!

from skeleton.