Giter Club home page Giter Club logo

Comments (5)

skazantsev avatar skazantsev commented on May 23, 2024

@gdgudmundson it looks like a bug in the library.

Currently, if you download a file using WebDavClient it tries to load it fully into memory instead of actually streaming it.

It can be fixed by adding HttpCompletionOption.ResponseHeadersRead to a request that is made by the underlying HttpClient but it requires additional changes to API to make response of GetRawFile and GetProcessedFile disposable.

I plan to fix it and release a new version of the library soon.

from webdavclient.

gdgudmundson avatar gdgudmundson commented on May 23, 2024

Another thing to consider is the ContentLength property on the WebDavResource class is an integer which only allows for 2GB file. It would need to be a long to support larger files.

I look forward to a new version.

Thanks!

from webdavclient.

skazantsev avatar skazantsev commented on May 23, 2024

Yeah, nice catch!

from webdavclient.

skazantsev avatar skazantsev commented on May 23, 2024

I have implemented a fix and released a new version to NuGet.

from webdavclient.

tipa avatar tipa commented on May 23, 2024

Any chance to make this an option in GetFileParameters so we can decide what HttpCompletionOption to use? In my use-case I am loading the stream into memory anyways and in order to call the Length or Position properties on the returned Stream from HttpClient, the HttpCompletionOption needs to be ResponseContentRead

from webdavclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.