Comments (2)
vogdb
commented on July 20, 2024
MediaAudioPlugin is extended by AudioroomPlugin and AudiobridgePlugin. AidioroomPlugin uses id for its entities. Audiobridge uses room. Because of that I had to do options = Helpers.extend({id: id}, options); or options = Helpers.extend({room: roomId}, options); in every action of those plugins.
How can we resolve this? It's hard to say. We can't put it inside MediaAudioPlugin cause it can not know id's key as room or id. We can't remove id from arguments cause we need it for _currentRoomId and we can't extract it from options without knowing its key room or id.
On the other hand keeping it as is now makes me wanna say WTF when I'm looking at it.
from janus-gateway-js.
njam
commented on July 20, 2024
Closing all tickets (unmaintained repo)
from janus-gateway-js.
Related Issues (20)
- Note about processing `ack` event HOT 5
- How to restart the whole thing? HOT 3
- VideoRoom Plugin Support HOT 2
- Adding a valid SIP address emits error HOT 1
- Support for REST http/https HOT 4
- Can i use it for React Native HOT 9
- plugin.textroom issue HOT 3
- Running on node? HOT 1
- Is there a current way to get all sessions on a janus instance? HOT 1
- Nativescript support HOT 1
- npm run-script build doen't work. HOT 1
- Data channel support (streaming plugin) HOT 3
- Video resolution HOT 1
- 报这个错是什么原因 HOT 2
- add getVolume HOT 6
- DataChannel support HOT 1
- Create integration tests for MediaPlugin and use an EchoTest plugin for testing. HOT 1
- Docu for events HOT 1
- Move chromium installation script into this repo HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from janus-gateway-js.