subpackage shouldn't show up in `__all__` about pybind11-stubgen HOT 5 CLOSED

Probably they way I currently populate __all__ is wrong. I think I need to do smth like this

globals_ = {}
exec("from {} import *".format(module_name), globals_)
all = set(globals_.keys()) - {"__builtins__"}

from pybind11-stubgen.

I think pylint might be confused here due to limited introspection in binary modules. With correct stubs for test project I have no complaints in pycharm.

At the moment pybind11-stubs does not handle properly import of modules under different name (equivalent in python: import foo as bar). This might be cause of some troubles for static analysis.

from pybind11-stubgen.

Closed in 1833492

from pybind11-stubgen.

Sorry for the delay @sizmailov... but that still causes the same problem. :) A better fix would have been removing just

-        for m in self.submodules:
-            _all_.append(m.short_name)

I think the reason pylint is complaining is that it would be expecting to find this:

__all__ = ['i', 'subpkg']
i: int
subpkg: module

And instead you're currently generating:

__all__ = ['i', 'subpkg']
i: int

I would expect instead for subpkg to not be in __all__, and that it wouldn't be a variable? So for the above example:

__all__ = ['i']
i: int

The reason I would expect this is because pybind11-stubgen is going to create a subpkg/__init__.pyi anyways, so the typechecker/etc will find that and use that?

from pybind11-stubgen.

__all__ = ['i', 'subpkg']
i: int = 3

This snippet is a fine piece of python code. pylint (2.6.0) does not report errors on dummy module/submodule setup similar to what you've posted earlier.
If it's ok for .py files, should be ok for .pyi as well. I think generated stubs are correct.

Again, I think it's lack of binary modules introspection or appreciation of stubs in pylint.

EDIT: add test module & pylint output

$ pylint pack/
************* Module pack
pack/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module pack.submodule
pack/submodule/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring)

------------------------------------------------------------------
Your code has been rated at 3.33/10 (previous run: 3.33/10, +0.00)

$ head pack/__init__.py pack/submodule/__init__.py 
==> pack/__init__.py <==
__all__ = ["CONST_I", "submodule"]
CONST_I: int = 3

==> pack/submodule/__init__.py <==
CONST = 5

from pybind11-stubgen.