Giter Club home page Giter Club logo

Comments (5)

 avatar commented on June 21, 2024

This is specifically not done because it would expose an additional global. Given that best practices with AMD discourage creating unnecessary globals, this is not something we really want to add to dgrid. As you say, however, it does present a challenge with the current Dojo parser.

Currently, the way to get around this is to expose any constructors you need parser to have access to yourself - which generally won't be the List module, but more likely the GridFromHtml module, or some constructor created using declare which mixes in GridFromHtml and any number of mixins/extensions. You can see examples of this done in some of the test pages, for example test/GridFromHtml.html (currently lines 91-92).

Note that currently there is also discussion going around for Dojo 1.8 to add support for parser to pick up data-dojo-type values which reference module identifiers (e.g. dgrid/GridFromHtml), which will make this less of a pain point.

Thanks for bringing this up though, I realize now that despite my memory suggesting otherwise, the README doesn't seem to make any mention of playing nicely with the parser. I'll see about adding a paragraph about that.

from dgrid.

neonstalwart avatar neonstalwart commented on June 21, 2024

fyi - the module identifier patch is in current trunk http://bugs.dojotoolkit.org/ticket/13778 for reference

from dgrid.

martinpengellyphillips avatar martinpengellyphillips commented on June 21, 2024

Thanks for the quick response, makes sense as well in the grand scheme.

from dgrid.

kitsonk avatar kitsonk commented on June 21, 2024

Yup, the only thing really under debate for 1.8 is whether the modules will have to be explicitly required before the parser is invoked. That means significant changes to the dojo/parser that maybe a step too far before 2.0.

from dgrid.

 avatar commented on June 21, 2024

Just added a note about using parser + dgrid in 1.7, in f6b4522

from dgrid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.